From: Schrober <franzschrober@yahoo.de>
To: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: Add control statement test to SINGLE_STATEMENT_DO_WHILE_MACRO
Date: Thu, 02 Aug 2012 18:44:57 +0200
Message-ID: <14936868.DMgLzkV3C3@bentobox>
User-Agent: KMail/4.8.4 (Linux/3.2.0-3-amd64; KDE/4.8.4; x86_64; ; )
In-Reply-To: <20120802162322.GI2501@dm>
References: <4204029.7cYAuJfu4T@bentobox> <1343921213.2011.9.camel@joe2Laptop> <20120802162322.GI2501@dm>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1322
Lines: 39

On Thursday 02 August 2012 17:23:22 Andy Whitcroft wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 913d6bd..ca05ba2 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3016,7 +3016,8 @@ sub process {
> > 
> >  					$herectx .= raw_line($linenr, $n) . "\n";
> >  				
> >  				}
> > 
> > -				if (($stmts =~ tr/;/;/) == 1) {
> > +				if (($stmts =~ tr/;/;/) == 1 &&
> > +				    $stmts !~ /^\s*(if|while|for|switch)\b/) {
> > 
> >  					WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
> >  					
> >  					     "Single statement macros should not use a do {} while 
(0)
> >  					     loop\n" . "$herectx");>  				
> >  				}
> 
> Looks reasonable enough.
> 
> Acked-by: Andy Whitcroft <apw@canonical.com>

Works well for me, thanks

Just as note: I think this test was accidently added twice. Once in commit 
b13edf7ff2dd0fef95e981170fa71fa6b60421b0 and one time in 
7d64ef43914a734990e48a80bc60686c8db21946 (just checked linux-next, and Stephen 
added it again). Maybe Andrew Morton's tree is out of sync.
-- 
Franz Schrober
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/