Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751087Ab2HCEhg (ORCPT ); Fri, 3 Aug 2012 00:37:36 -0400 Received: from tundra.namei.org ([65.99.196.166]:40503 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744Ab2HCEhe (ORCPT ); Fri, 3 Aug 2012 00:37:34 -0400 Date: Fri, 3 Aug 2012 14:37:27 +1000 (EST) From: James Morris To: Kees Cook cc: Heiko Carstens , Will Drewry , James Morris , linux-kernel@vger.kernel.org Subject: Re: [PATCH] samples/seccomp: fix endianness bug in LO_ARG define In-Reply-To: Message-ID: References: <20120731141536.GA4262@osiris.boeblingen.de.ibm.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 30 On Tue, 31 Jul 2012, Kees Cook wrote: > On Tue, Jul 31, 2012 at 7:15 AM, Heiko Carstens > wrote: > > From: Heiko Carstens > > > > The LO_ARG define needs to consider endianness also for 32 bit builds. > > > > The "bpf_fancy" test case didn't work on s390 in 32 bit and compat mode > > because the LO_ARG define resulted in a BPF program which read the upper > > halve of the 64 bit system call arguments instead of the lower halves. > > > > Signed-off-by: Heiko Carstens > > Good catch; thanks for the fix! > > Acked-by: Kees Cook Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/