Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751750Ab2HCH1H (ORCPT ); Fri, 3 Aug 2012 03:27:07 -0400 Received: from eu1sys200aog113.obsmtp.com ([207.126.144.135]:40168 "EHLO eu1sys200aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118Ab2HCH1G convert rfc822-to-8bit (ORCPT ); Fri, 3 Aug 2012 03:27:06 -0400 From: Virupax SADASHIVPETIMATH To: Alan Stern Cc: "balbi@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Praveena NADAHALLY , Vikrant BAPAT , Rajaram REGUPATHY Date: Fri, 3 Aug 2012 09:26:29 +0200 Subject: RE: [PATCH] usb:musb:musb_host: Handle highmem in PIO mode Thread-Topic: [PATCH] usb:musb:musb_host: Handle highmem in PIO mode Thread-Index: Ac1wveIxNZ/EtknUSuCr/sHqAgVZdQAiwtdw Message-ID: References: <1343889402-7826-1-git-send-email-virupax.sadashivpetimath@stericsson.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 41 > -----Original Message----- > From: Alan Stern [mailto:stern@rowland.harvard.edu] > Sent: Thursday, August 02, 2012 8:18 PM > To: Virupax SADASHIVPETIMATH > Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux- > kernel@vger.kernel.org; Praveena NADAHALLY > Subject: Re: [PATCH] usb:musb:musb_host: Handle highmem in PIO mode > > > --- a/include/linux/usb.h > > +++ b/include/linux/usb.h > > @@ -21,6 +21,7 @@ > > #include /* for current && schedule_timeout */ > > #include /* for struct mutex */ > > #include /* for runtime PM */ > > +#include > > > > struct usb_device; > > struct usb_driver; > > @@ -1309,6 +1310,7 @@ struct urb { > > usb_complete_t complete; /* (in) completion routine */ > > struct usb_iso_packet_descriptor iso_frame_desc[0]; > > /* (in) ISO ONLY */ > > + struct sg_mapping_iter sg_miter; /* handling highmem data in PIO mode */ > > }; > > This is unacceptable. Fields like this should be stored in the > URB's hcpriv structure, not in the URB itself. Ok I will add it in the hcpriv structure. Can you please comment on other part of the code also, so that all the changes can be done together. Thanks Virupax S -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/