Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404Ab2HCKmM (ORCPT ); Fri, 3 Aug 2012 06:42:12 -0400 Received: from mail.skyhub.de ([78.46.96.112]:32941 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187Ab2HCKmK (ORCPT ); Fri, 3 Aug 2012 06:42:10 -0400 Date: Fri, 3 Aug 2012 12:42:12 +0200 From: Borislav Petkov To: Kay Sievers Cc: "Pandita, Vikram" , Venu Byravarasu , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , Mike Turquette , Vimarsh Zutshi Subject: Re: [PATCH v2] printk: add option to print cpu id Message-ID: <20120803104212.GA6936@x1.osrc.amd.com> Mail-Followup-To: Borislav Petkov , Kay Sievers , "Pandita, Vikram" , Venu Byravarasu , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , Mike Turquette , Vimarsh Zutshi References: <1343985378-22330-1-git-send-email-vikram.pandita@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 34 On Fri, Aug 03, 2012 at 12:09:15PM +0200, Kay Sievers wrote: > That would be needed, I guess. We easily have server systems with more > than 255 CPUs. It will only be a matter of time, that the number of > CPUs will increase for everybody, I guess. Actually, AFAICR, we already have SGI machines booting Linux on 4K cpus. Now. > > b) to put cpuid in struct cont and struct log - under the #ifdef macro? > > As said, I really can't tell how generally useful it is, and if people > think that it should be there unconditionally, should not be there at > all, or as a compile time option. Others might have an opinion on > that. > > I personally never missed the CPU-ID in the logs. I personally would > find the PID/task ID more interesting, and even that I never really > missed. :) And even then you can add debugging code to dump the stuff you need. And I have to agree with Kai here, having the cpu number in dmesg is not something I'd wish for - printk timestampts OTOH has at least some usecases. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/