Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430Ab2HCMuT (ORCPT ); Fri, 3 Aug 2012 08:50:19 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:39334 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753875Ab2HCMuO convert rfc822-to-8bit (ORCPT ); Fri, 3 Aug 2012 08:50:14 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1485\)) Subject: Re: [PATCH 3/4] arm/dts: omap5-evm: Add keypad data From: Koen Kooi In-Reply-To: <1343997486-710-4-git-send-email-sourav.poddar@ti.com> Date: Fri, 3 Aug 2012 14:50:22 +0200 Cc: , , , , Benoit Cousson , Felipe Balbi , Santosh Shilimkar Content-Transfer-Encoding: 8BIT Message-Id: References: <1343997486-710-1-git-send-email-sourav.poddar@ti.com> <1343997486-710-4-git-send-email-sourav.poddar@ti.com> To: Sourav Poddar X-Mailer: Apple Mail (2.1485) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1772 Lines: 49 Op 3 aug. 2012, om 14:38 heeft Sourav Poddar het volgende geschreven: > Add keypad data node in omap5 device tree file. > Also fill the device tree binding parameters > with the required value in "omap5-evm" dts file. > > Tested on omap5430 evm with 3.5 custom kernel. > > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > Acked-by: Felipe Balbi > Signed-off-by: Sourav Poddar > --- > arch/arm/boot/dts/omap5-evm.dts | 12 ++++++++++++ > arch/arm/boot/dts/omap5.dtsi | 5 +++++ > 2 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts > index 45a8aeb..09fe941 100644 > --- a/arch/arm/boot/dts/omap5-evm.dts > +++ b/arch/arm/boot/dts/omap5-evm.dts > @@ -17,6 +17,18 @@ > device_type = "memory"; > reg = <0x80000000 0x40000000>; /* 1 GB */ > }; > + > + keypad { > + keypad,num-rows = <8>; > + keypad,num-columns = <8>; > + linux,keymap = < 0x02020073 > + 0x02030072 > + 0x020400e7 > + 0x02050066 > + 0x0206006b > + 0x020700d9 >; > + linux,input-no-autorepeat; > + }; This not a criticism on your patch, but a generic question about DT: Is there no way to have nice constants for keys like we have in the kernel, like KEY_POWER, KEY_UP, etc? If no, does DT allow comments so I can look at a dts and see which keycodes are mapped instead of having to dig up the sources? regards, Koen-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/