Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753602Ab2HCP6o (ORCPT ); Fri, 3 Aug 2012 11:58:44 -0400 Received: from seven.medozas.de ([5.9.24.206]:34505 "EHLO seven.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126Ab2HCP6j (ORCPT ); Fri, 3 Aug 2012 11:58:39 -0400 Date: Fri, 3 Aug 2012 17:58:38 +0200 (CEST) From: Jan Engelhardt To: OGAWA Hirofumi cc: "Steven J. Magnani" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fat: Refactor shortname parsing In-Reply-To: <87lihw10cs.fsf@devron.myhome.or.jp> Message-ID: References: <1341314074-2867-1-git-send-email-steve@digidescorp.com> <87lihw10cs.fsf@devron.myhome.or.jp> User-Agent: Alpine 2.01 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 21 On Friday 2012-08-03 17:06, OGAWA Hirofumi wrote: >>>+static inline unsigned char fat_tolower(unsigned char c) >>>+{ >>>+ return ((c >= 'A') && (c <= 'Z')) ? c+32 : c; >>>+} >>>+ >> >> The kernel already has a tolower() function, can that not be used? > >tolower() is not exactly same, right? e.g. tolower(0xc0). Otherwise, >tolower() is fine. Yes, but you can still return (c >= 'A' && c <= 'Z') ? tolower(c) : c; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/