Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849Ab2HCWNe (ORCPT ); Fri, 3 Aug 2012 18:13:34 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:53769 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753450Ab2HCWNb (ORCPT ); Fri, 3 Aug 2012 18:13:31 -0400 Date: Fri, 3 Aug 2012 15:13:27 -0700 From: Greg KH To: "Pandita, Vikram" Cc: Aaro Koskinen , Andi Kleen , kay@vrfy.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mike Turquette , Vimarsh Zutshi Subject: Re: [PATCH v3] printk: add option to print cpu id Message-ID: <20120803221327.GA5102@kroah.com> References: <1344013004-32211-1-git-send-email-vikram.pandita@ti.com> <20120803200822.GC731@harshnoise.musicnaut.iki.fi> <20120803215954.GA4489@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 41 On Fri, Aug 03, 2012 at 03:07:39PM -0700, Pandita, Vikram wrote: > On Fri, Aug 3, 2012 at 2:59 PM, Greg KH wrote: > > On Fri, Aug 03, 2012 at 02:24:20PM -0700, Pandita, Vikram wrote: > >> Aaro > >> > >> On Fri, Aug 3, 2012 at 1:08 PM, Aaro Koskinen wrote: > >> > Hi, > >> > > >> > On Fri, Aug 03, 2012 at 11:25:37AM -0700, Pandita, Vikram wrote: > >> >> > And really: Wasting 1/3 of the 80 character line is too much. > >> >> > >> >> You _WASTE_ 4 chars only if you are interested in this info by > >> >> enabling: CONFIG_PRINTK_CPUID > >> > > >> > I guess you waste 4 + 3 chars? You could optimize the length by checking > >> > CONFIG_NR_CPUS? > >> > >> Good point. > >> Looks there is a variable 'nr_cpu_ids' that could be used as well. > >> > >> If there is general consensus that the patch can help the arm > >> community, and others in general, > >> this optimization should be easy to implement - saving few chars space > >> in each line of console output. > >> > >> For now i will stick to this v3 version of path, unless you think otherwise. > > > > I don't think is is something that anyone needs, and if you do, as > > pointed out, you can use the trace function to make it happen. > > > > This was something that got used internally and helped at times. Could you have used the trace point instead? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/