Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755096Ab2HEVTg (ORCPT ); Sun, 5 Aug 2012 17:19:36 -0400 Received: from 1010ds2-suoe.0.fullrate.dk ([90.184.90.115]:24575 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755015Ab2HEVTf (ORCPT ); Sun, 5 Aug 2012 17:19:35 -0400 Date: Sun, 5 Aug 2012 23:19:34 +0200 (CEST) From: Jesper Juhl To: Daniel Vetter cc: David Airlie , Daniel Vetter , Jesse Barnes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd() In-Reply-To: <20120805210044.GE12232@phenom.ffwll.local> Message-ID: References: <20120805210044.GE12232@phenom.ffwll.local> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 23 On Sun, 5 Aug 2012, Daniel Vetter wrote: > On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote: > > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails > > we'll return false and leak 'buf' when it goes out of scope. > > > > Signed-off-by: Jesper Juhl > > I've already merged a similar patch from Alan Cox for -fixes, should land > in 3.6 soonish. Perfect. -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/