Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755585Ab2HFDlj (ORCPT ); Sun, 5 Aug 2012 23:41:39 -0400 Received: from g1t0029.austin.hp.com ([15.216.28.36]:11641 "EHLO g1t0029.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755545Ab2HFDli (ORCPT ); Sun, 5 Aug 2012 23:41:38 -0400 Message-ID: <1344224494.3053.5.camel@lorien2> Subject: Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create() From: Shuah Khan Reply-To: shuah.khan@hp.com To: Pekka Enberg Cc: cl@linux.com, glommer@parallels.com, js1304@gmail.com, linux-mm@kvack.org, LKML , Andrew Morton , Linus Torvalds , David Rientjes , shuahkhan@gmail.com Date: Sun, 05 Aug 2012 21:41:34 -0600 In-Reply-To: References: <1342221125.17464.8.camel@lorien2> Organization: ISS-Linux Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 30 On Mon, 2012-07-30 at 13:18 +0300, Pekka Enberg wrote: > On Sat, Jul 14, 2012 at 2:12 AM, Shuah Khan wrote: > > The label oops is used in CONFIG_DEBUG_VM ifdef block and is defined > > outside ifdef CONFIG_DEBUG_VM block. This results in the following > > build warning when built with CONFIG_DEBUG_VM disabled. Fix to move > > label oops definition to inside a CONFIG_DEBUG_VM block. > > > > mm/slab_common.c: In function ‘kmem_cache_create’: > > mm/slab_common.c:101:1: warning: label ‘oops’ defined but not used > > [-Wunused-label] > > > > Signed-off-by: Shuah Khan > > I merged this as an obvious and safe fix for current merge window. We > need to clean this up properly for v3.7. Thanks for merging the obvious fix. I was on vacation for the last two weeks, and just got back. I sent another patch that restructures the debug and non-debug code right before I went on vacation. Didn't get a chance to look at the responses (if any). Will get working on following up and re-working and re-sending the patch as needed this week. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/