Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471Ab2HFHfg (ORCPT ); Mon, 6 Aug 2012 03:35:36 -0400 Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]:49829 "EHLO na3sys009aog117.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024Ab2HFHff (ORCPT ); Mon, 6 Aug 2012 03:35:35 -0400 MIME-Version: 1.0 In-Reply-To: <501BE6B1.9000100@ti.com> References: <1343997350-676-1-git-send-email-sourav.poddar@ti.com> <501BE6B1.9000100@ti.com> Date: Mon, 6 Aug 2012 13:05:34 +0530 Message-ID: Subject: Re: [PATCH] hwmon: tmp102: Add device tree support From: "Poddar, Sourav" To: Benoit Cousson Cc: khali@linux-fr.org, linux@roeck-us.net, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Santosh Shilimkar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1902 Lines: 60 Hi Benoit, On Fri, Aug 3, 2012 at 8:26 PM, Benoit Cousson wrote: > Hi Sourav, > > On 08/03/2012 02:35 PM, Sourav Poddar wrote: >> update tmp102 temperature sensor to also use device tree. >> >> Cc: Benoit Cousson >> Cc: Felipe Balbi >> Cc: Santosh Shilimkar >> Acked-by: Felipe Balbi >> Signed-off-by: Sourav Poddar >> --- >> drivers/hwmon/tmp102.c | 14 +++++++++++++- >> 1 files changed, 13 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c >> index 0d466b9..a8a9060 100644 >> --- a/drivers/hwmon/tmp102.c >> +++ b/drivers/hwmon/tmp102.c >> @@ -26,6 +26,7 @@ >> #include >> #include >> #include >> +#include >> >> #define DRIVER_NAME "tmp102" >> >> @@ -284,8 +285,19 @@ static const struct i2c_device_id tmp102_id[] = { >> }; >> MODULE_DEVICE_TABLE(i2c, tmp102_id); >> >> +#ifdef CONFIG_OF >> +static const struct of_device_id temperature_dt_match[] = { >> + { .compatible = "ti,tmp102" }, > > Are you sure this is needed for this device? > > There is an automatic binding done for I2C devices in the of_i2c core > code. So in theory, DT will be able to bind to any I2C device using the > already existing table: MODULE_DEVICE_TABLE(i2c, tmp102_id). > > So I think this patch should not be needed. > Indeed. Checked it just now, this patch is not required and the already existing table is enough for the device to work fine. Thanks for the information. This patch is abandoned. ~Sourav > Regards, > Benoit > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/