Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013Ab2HFKVU (ORCPT ); Mon, 6 Aug 2012 06:21:20 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36292 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316Ab2HFKVR (ORCPT ); Mon, 6 Aug 2012 06:21:17 -0400 Date: Mon, 6 Aug 2012 12:21:14 +0200 From: Pavel Machek To: Len Brown Cc: Alan Stern , linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Len Brown , Pavel Vasilyev Subject: Re: [linux-pm] [PATCH] ACPI: replace strlen("string") with sizeof("string") -1 Message-ID: <20120806102114.GA31404@elf.ucw.cz> References: <5011F15A.3060007@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5011F15A.3060007@kernel.org> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 24 On Thu 2012-07-26 21:39:38, Len Brown wrote: > ...both give the number of chars in the string > without the '\0', as strncmp() wants, > but sizeof() is compile-time. What about introducing something like streq() to do this automatically? This is ugly.... #define streq(a, b) ... if (_buildin_constant(b)) ... ? > - if (!strncmp(val, "enable", strlen("enable"))) { > + if (!strncmp(val, "enable", sizeof("enable") - 1)) { Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/