Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234Ab2HFN4D (ORCPT ); Mon, 6 Aug 2012 09:56:03 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:25886 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756178Ab2HFN4A (ORCPT ); Mon, 6 Aug 2012 09:56:00 -0400 Date: Mon, 6 Aug 2012 16:55:56 +0300 From: Dan Carpenter To: Devendra Naga Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Veli-Pekka Peltola , Mikko =?iso-8859-1?Q?Virkkil=E4?= , Riku =?iso-8859-1?Q?Mett=E4l=E4?= , Lauri Hintsala Subject: Re: [PATCH 1/5] staging/csr: clean coding style in uf_start_thread Message-ID: <20120806135556.GA9956@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 21 This was sent encoded as base64 which is awkward. On Sat, Aug 04, 2012 at 01:01:38PM +0545, Devendra Naga wrote: > - } else { > - priv->bh_thread.prio = DEFAULT_PRIO; > - } > + } else > + priv->bh_thread.prio = DEFAULT_PRIO; Probably it's not worth resending if this is the only complaint, but actually the original had that braces correct. If either side of the if else statement gets uses curly braces then both sides should use them. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/