Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756573Ab2HFOXz (ORCPT ); Mon, 6 Aug 2012 10:23:55 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:49623 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756550Ab2HFOXv (ORCPT ); Mon, 6 Aug 2012 10:23:51 -0400 Date: Mon, 6 Aug 2012 17:23:23 +0300 From: Dan Carpenter To: Julia Lawall Cc: Mauro Carvalho Chehab , kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get Message-ID: <20120806142323.GO4352@mwanda> References: <1344104607-18805-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1344104607-18805-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 27 On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: > @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, pcdev); > > - if (devm_request_mem_region(&pdev->dev, res_emma->start, > - resource_size(res_emma), MEM2MEM_NAME) == NULL) > - goto rel_vdev; > - > - pcdev->base_emma = devm_ioremap(&pdev->dev, res_emma->start, > - resource_size(res_emma)); > + pcdev->base_emma = devm_request_and_ioremap(&pdev->dev, res_emma); > if (!pcdev->base_emma) > goto rel_vdev; This was in the original code, but there is a "ret = -ENOMEM;" missing here, and again a couple lines down in the original code. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/