Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932098Ab2HFOmP (ORCPT ); Mon, 6 Aug 2012 10:42:15 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:34362 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754782Ab2HFOmO (ORCPT ); Mon, 6 Aug 2012 10:42:14 -0400 MIME-Version: 1.0 In-Reply-To: <20120806143016.GK16861@opensource.wolfsonmicro.com> References: <1344184373-9670-1-git-send-email-haojian.zhuang@gmail.com> <20120806143016.GK16861@opensource.wolfsonmicro.com> Date: Mon, 6 Aug 2012 22:42:12 +0800 Message-ID: Subject: Re: [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM From: Haojian Zhuang To: Mark Brown Cc: sameo@linux.intel.com, rpurdie@rpsys.net, bryan.wu@canonical.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 25 On Mon, Aug 6, 2012 at 10:30 PM, Mark Brown wrote: > On Mon, Aug 06, 2012 at 12:32:48AM +0800, Haojian Zhuang wrote: > >> Since IORESOURCE_IO is used for PCI devices, it doesn't fit on >> 88PM860x PMIC device that lies on I2C bus. So use IORESOURCE_MEM >> instead. > > This isn't much more appropriate - _MEM is for memory ranges so isn't > directly relevant to register addresses either. If anything _IO is > slightly nearer. I use register resource to distinguish different components now. For example, component driver needs to access the registers in PMIC. These registers offsets are set in 88pm860x-core.c. So I think that it may not be called _IO. Regards Haojian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/