Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756577Ab2HFPrR (ORCPT ); Mon, 6 Aug 2012 11:47:17 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:33595 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756332Ab2HFPrQ (ORCPT ); Mon, 6 Aug 2012 11:47:16 -0400 MIME-Version: 1.0 Reply-To: axel.lin@gmail.com In-Reply-To: <20120704154821.GG4111@opensource.wolfsonmicro.com> References: <1341369105.10587.8.camel@phoenix> <20120704154821.GG4111@opensource.wolfsonmicro.com> From: Axel Lin Date: Mon, 6 Aug 2012 23:46:55 +0800 Message-ID: Subject: Re: [PATCH RFT] regulator: ab8500: Set enable enable_time in regulator_desc To: Mark Brown Cc: Lee Jones , Linus Walleij , Liam Girdwood , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 27 2012/7/4 Mark Brown : > On Wed, Jul 04, 2012 at 10:31:45AM +0800, Axel Lin wrote: >> Signed-off-by: Axel Lin >> --- >> Hi Linus, >> While working on this patch, I found in original code: >> ab8500_regulator_ops set enable_time callback to ab8500_regulator_enable_time, >> but does not set the delay in ab8500_regulator_info. >> I'm not sure the delay value is 0 for ab8500_regulator_ops, or the setting is >> just missing. >> Anyway, there is no behavior change by this patch. > > Surely if the delay is not set in info then it'll introduce a delay > which wasn't there before (but which may well be a bug fix)? Ping... Hi Linus, Any comments on this patch? Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/