Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932346Ab2HFQtG (ORCPT ); Mon, 6 Aug 2012 12:49:06 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:48523 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932271Ab2HFQtE (ORCPT ); Mon, 6 Aug 2012 12:49:04 -0400 MIME-Version: 1.0 In-Reply-To: <1344266096.2486.17.camel@lorien2> References: <1342221125.17464.8.camel@lorien2> <1344224494.3053.5.camel@lorien2> <1344266096.2486.17.camel@lorien2> Date: Tue, 7 Aug 2012 01:49:03 +0900 Message-ID: Subject: Re: [PATCH RESEND] mm: Restructure kmem_cache_create() to move debug cache integrity checks into a new function From: JoonSoo Kim To: shuah.khan@hp.com Cc: Pekka Enberg , cl@linux.com, glommer@parallels.com, linux-mm@kvack.org, LKML , Andrew Morton , Linus Torvalds , David Rientjes , shuahkhan@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1997 Lines: 61 > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 12637ce..08bc2a4 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -23,6 +23,41 @@ enum slab_state slab_state; > LIST_HEAD(slab_caches); > DEFINE_MUTEX(slab_mutex); > > +static int kmem_cache_sanity_check(const char *name, size_t size) > +{ > +#ifdef CONFIG_DEBUG_VM > + struct kmem_cache *s = NULL; > + > + list_for_each_entry(s, &slab_caches, list) { > + char tmp; > + int res; > + > + /* > + * This happens when the module gets unloaded and doesn't > + * destroy its slab cache and no-one else reuses the vmalloc > + * area of the module. Print a warning. > + */ > + res = probe_kernel_address(s->name, tmp); > + if (res) { > + pr_err("Slab cache with size %d has lost its name\n", > + s->object_size); > + continue; > + } > + > + if (!strcmp(s->name, name)) { > + pr_err("%s (%s): Cache name already exists.\n", > + __func__, name); > + dump_stack(); > + s = NULL; > + return -EINVAL; > + } > + } > + > + WARN_ON(strchr(name, ' ')); /* It confuses parsers */ > +#endif > + return 0; > +} As I know, following is more preferable than above. #ifdef CONFIG_DEBUG_VM static int kmem_cache_sanity_check(const char *name, size_t size); #else static inline int kmem_cache_sanity_check(const char *name, size_t size) { return 0; } #endif Is there any reason to do like that? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/