MIME-Version: 1.0
In-Reply-To: <20120806181436.GF21441@infradead.org>
References: <1344247319-304069-1-git-send-email-avagin@openvz.org>
	<1344247319-304069-4-git-send-email-avagin@openvz.org>
	<20120806181436.GF21441@infradead.org>
Date: Mon, 6 Aug 2012 23:50:53 +0400
Message-ID: <CANaxB-xffLyn00U-dHMxkEXQZ7nMBxTyTcfgJnaah0rBaDCrKg@mail.gmail.com>
Subject: Re: [PATCH 3/3] perf: mark a dso if it's used
From: Andrey Wagin <avagin@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1640
Lines: 38

2012/8/6 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> Em Mon, Aug 06, 2012 at 02:01:59PM +0400, Andrew Vagin escreveu:
>> -     if (inject_build_ids) {
>> +     if (inject_build_ids || inject_sched_stat) {
>>               perf_inject.sample       = perf_event__inject_buildid;
>>               perf_inject.mmap         = perf_event__repipe_mmap;
>>               perf_inject.fork         = perf_event__repipe_task;
>>               perf_inject.tracing_data = perf_event__repipe_tracing_data;
>> -     } else if (inject_sched_stat) {
>> +     }
>> +
>> +     if (inject_sched_stat) {
>>               perf_inject.sample      = perf_event__sched_stat;
>>               perf_inject.ordered_samples = true;
>>       }
>
> Huh? so if inject_sched_stat is true we will first set
> perf_inject.sample to something, then to another?

Yes, we will. I though that it will be better then this:

if (inject_build_ids || inject_sched_stat) {
               perf_inject.mmap         = perf_event__repipe_mmap;
               perf_inject.fork         = perf_event__repipe_task;
               perf_inject.tracing_data = perf_event__repipe_tracing_data;
}

if (inject_build_ids) {
               perf_inject.sample       = perf_event__inject_buildid;
} else if (inject_sched_stat) {
               perf_inject.sample      = perf_event__sched_stat;
               perf_inject.ordered_samples = true;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/