Date: Mon, 06 Aug 2012 13:47:37 -0700 (PDT)
Message-Id: <20120806.134737.1358773847818872075.davem@davemloft.net>
To: ebiederm@xmission.com
Cc: vyasevich@gmail.com, jan.ariyasu@gmail.com, linux-sctp@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        jan.ariyasu@hp.com
Subject: Re: [PATCH 00/13] SCTP: Enable netns
From: David Miller <davem@davemloft.net>
In-Reply-To: <874noflrzd.fsf@xmission.com>
References: <87mx27rig7.fsf@xmission.com>
	<50201928.2030802@gmail.com>
	<874noflrzd.fsf@xmission.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 972
Lines: 26

From: ebiederm@xmission.com (Eric W. Biederman)
Date: Mon, 06 Aug 2012 12:50:46 -0700

> Vlad Yasevich <vyasevich@gmail.com> writes:
> 
> 
>> Hi Eric
>>
>> Associations are looked up by ports, but then verifyed by addresses.
>> Also, associations belong to sockets and simply validating the socket
>> namespace should be sufficient.
> 
> True.  Your set of patches isn't quite as likely to malfunction as it
> looked at first glance.  It requires address reuse which happens accross
> namespaces but not too frequently.
> 
> As for validating the socket namespace I agree that is the fix and my
> patchset winds up doing it.

FWIW I much prefer Eric's patch set, it was so significantly easier to
read and validate than Jan's.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/