Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756259Ab2HFWIE (ORCPT ); Mon, 6 Aug 2012 18:08:04 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:38264 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755808Ab2HFWIB (ORCPT ); Mon, 6 Aug 2012 18:08:01 -0400 From: Dmitry Torokhov To: Greg KH Cc: Yann Cantin , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device Date: Mon, 06 Aug 2012 15:07:46 -0700 Message-ID: <1975621.3ErbANJ9at@dtor-d630.eng.vmware.com> User-Agent: KMail/4.8.4 (Linux/3.5.0-2.fc17.x86_64; KDE/4.8.4; x86_64; ; ) In-Reply-To: <20120806214340.GA30355@kroah.com> References: <1344288104-20731-1-git-send-email-yann.cantin@laposte.net> <1344288104-20731-2-git-send-email-yann.cantin@laposte.net> <20120806214340.GA30355@kroah.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 38 On Monday, August 06, 2012 02:43:40 PM Greg KH wrote: > On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > > --- > > > > drivers/hid/hid-core.c | 3 +++ > > drivers/hid/hid-ids.h | 3 +++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index 60ea284..b1ed8ee 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -1908,6 +1908,9 @@ static const struct hid_device_id hid_ignore_list[] > > = {> > > { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) > > }, > > { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) }, > > { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) }, > > > > +#if defined(CONFIG_INPUT_EBEAM_USB) > > + { HID_USB_DEVICE(USB_VENDOR_ID_EFI, USB_DEVICE_ID_EFI_CLASSIC) }, > > +#endif > > Why is this #if in here? Just always do it, how could it not be > defined? User might disable the driver and CONFIG_INPUT_EBEAM_USB will not be set. But I agree, since the device is unusable with generic HID driver there is no point in doing this conditionally. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/