From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Yann Cantin <yann.cantin@laposte.net>, linux-input@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC ebeam PATCH v3 0/2]
Date: Mon, 06 Aug 2012 15:09:01 -0700
Message-ID: <1743577.8bRY3CPqxH@dtor-d630.eng.vmware.com>
User-Agent: KMail/4.8.4 (Linux/3.5.0-2.fc17.x86_64; KDE/4.8.4; x86_64; ; )
In-Reply-To: <20120806214423.GC30355@kroah.com>
References: <1344288104-20731-1-git-send-email-yann.cantin@laposte.net> <20120806214423.GC30355@kroah.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1355
Lines: 40

On Monday, August 06, 2012 02:44:23 PM Greg KH wrote:
> On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote:
> > Hi,
> > 
> > New USB input driver for eBeam devices.
> > 
> > Currently, only the Luidia eBeam classic projection model is supported.
> > Edge model and a NEC interactive video-projector support planned for the
> > end of the mounth.
> > 
> > Patch 1 to blacklist the device for hid generic-usb.
> > 
> > Patch 2 is the actual driver.
> > 
> > Changes from previous :
> > - switch to div64_s64 for portable 64/64-bits divisions

Do you really need this much precision? It will be slower on 32 bits..

> > - some cosmetics in device name
> > - unused include and def removed
> > - variables name changes for readability
> > 
> > Pending issues :
> > 
> > - sysfs custom files : need to pass 13 parameters for calibration :
> >   choice is between lots of simply-handled, or few with a big sscanf.
> 
> sysfs is "one value per file", so use lots of different files please.

This is kind of a "one value" though - it is a transformation matrix.
Maybe switch it to binary - 9 s32?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/