Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932327Ab2HGBpa (ORCPT ); Mon, 6 Aug 2012 21:45:30 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:43340 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932257Ab2HGBpX (ORCPT ); Mon, 6 Aug 2012 21:45:23 -0400 Message-ID: <50207357.5080208@laposte.net> Date: Tue, 07 Aug 2012 03:45:59 +0200 From: Yann Cantin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120717 Thunderbird/10.0.6 MIME-Version: 1.0 To: Dmitry Torokhov CC: Greg KH , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC ebeam PATCH v3 0/2] References: <1344288104-20731-1-git-send-email-yann.cantin@laposte.net> <20120806214423.GC30355@kroah.com> <1743577.8bRY3CPqxH@dtor-d630.eng.vmware.com> In-Reply-To: <1743577.8bRY3CPqxH@dtor-d630.eng.vmware.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 51 Le 07/08/2012 00:09, Dmitry Torokhov a ?crit : > On Monday, August 06, 2012 02:44:23 PM Greg KH wrote: >> On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote: >>> Hi, >>> >>> New USB input driver for eBeam devices. >>> >>> Currently, only the Luidia eBeam classic projection model is supported. >>> Edge model and a NEC interactive video-projector support planned for the >>> end of the mounth. >>> >>> Patch 1 to blacklist the device for hid generic-usb. >>> >>> Patch 2 is the actual driver. >>> >>> Changes from previous : >>> - switch to div64_s64 for portable 64/64-bits divisions > > Do you really need this much precision? It will be slower on 32 bits.. Yes. I can give the details if you want (homography computation without floating point maths). >>> - some cosmetics in device name >>> - unused include and def removed >>> - variables name changes for readability >>> >>> Pending issues : >>> >>> - sysfs custom files : need to pass 13 parameters for calibration : >>> choice is between lots of simply-handled, or few with a big sscanf. >> >> sysfs is "one value per file", so use lots of different files please. > > This is kind of a "one value" though - it is a transformation matrix. > Maybe switch it to binary - 9 s32? Right, but this somehow obfuscate the api. In the other hand, i doubt there will be lots of calibration tools other that mine. Is there any drawback for numerous sysfs custom files ? -- Yann Cantin A4FEB47F -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/