Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499Ab2HGPJm (ORCPT ); Tue, 7 Aug 2012 11:09:42 -0400 Received: from mail.active-venture.com ([67.228.131.205]:52616 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033Ab2HGPJl (ORCPT ); Tue, 7 Aug 2012 11:09:41 -0400 X-Originating-IP: 108.223.40.66 Date: Tue, 7 Aug 2012 08:09:49 -0700 From: Guenter Roeck To: "Opensource [Anthony Olech]" Cc: Guenter Roeck , Jean Delvare , Randy Dunlop , Mark Brown , David Dajun Chen , LKML , "lm-sensors@lm-sensors.org" Subject: Re: [lm-sensors] [NEW DRIVER V2 6/7] DA9058 HWMON driver Message-ID: <20120807150949.GA25007@roeck-us.net> References: <201208060737.q767biox005703@ubuntu> <20120806173943.GA29475@roeck-us.net> <24DF37198A1E704D9811D8F72B87EB51032C3BBB@NB-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24DF37198A1E704D9811D8F72B87EB51032C3BBB@NB-EX-MBX02.diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2806 Lines: 62 On Tue, Aug 07, 2012 at 12:10:08PM +0000, Opensource [Anthony Olech] wrote: > > -----Original Message----- > > From: Guenter Roeck [mailto:linux@roeck-us.net] > > Sent: 06 August 2012 18:40 > > To: Opensource [Anthony Olech] > > Cc: Guenter Roeck; Jean Delvare; Randy Dunlop; Mark Brown; David Dajun > > Chen; LKML; lm-sensors@lm-sensors.org > > Subject: Re: [lm-sensors] [NEW DRIVER V2 6/7] DA9058 HWMON driver > > On Sun, Aug 05, 2012 at 09:43:44PM +0100, Anthony Olech wrote: > > > This is the HWMON component driver of the Dialog DA9058 PMIC. > > > This driver is just one component of the whole DA9058 PMIC driver. > > > It depends on the core DA9058 MFD driver. > > > Signed-off-by: Anthony Olech > > > Signed-off-by: David Dajun Chen > > [ ... ] > > > +static SENSOR_DEVICE_ATTR(vbat_mV, S_IRUGO, da9058_read_vbat, NULL, > > > +0); static SENSOR_DEVICE_ATTR(adc_mV, S_IRUGO, > > da9058_read_misc_channel, NULL, > > > + DA9058_ADCMAN_MUXSEL_ADCIN); > > > +static SENSOR_DEVICE_ATTR(vfpin_mV, S_IRUGO, da9058_read_vfpin, > > NULL, > > > +0); static SENSOR_DEVICE_ATTR(vfpin_mode, S_IRUGO, > > da9058_vfpin_mode, > > > +NULL, 0); static SENSOR_DEVICE_ATTR(tbat_mV, S_IRUGO, > > > +da9058_read_tbat, NULL, 0); static SENSOR_DEVICE_ATTR(tjunc_in, > > > +S_IRUGO, da9058_read_tjunc, NULL, 0); static > > SENSOR_DEVICE_ATTR(adc_mode, S_IWUSR | S_IRUGO, > > da9058_get_adc_mode, > > > + da9058_set_adc_mode, 0); > > Please use standard sysfs attribute names for temperature and voltage attributes. > > I could not find a naming convention, so I will try to abstract one from all the Documentation/hwmon/sysfs-interface might be a good start. > HWMON driver that have your name in them. I noted when searching that > I missed out a file in also that Documentation/hwmon. I will correct both > issues in my next submission attempt. > > > For configuration (XXX_mode), please use devicetreee and/or platform data, > > not sysfs attributes. > > As far as I can see both devicetreee and platform data allow configuration > data to be passed into the driver at "probe" time, they don't allow an operating > mode to be changed dynamically. That is what I thought sysfs allowed. Thus > your comments seem to imply that you do not want to allow the mode to be > changed dynamically. If that is the case then I can remove the dynamic mode Correct. > setting, leaving it fixed by platform data. > I would also suggest to read and follow Documentation/hwmon/submitting-patches. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/