Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755601Ab2HGQuX (ORCPT ); Tue, 7 Aug 2012 12:50:23 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:47901 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755534Ab2HGQuW (ORCPT ); Tue, 7 Aug 2012 12:50:22 -0400 Date: Tue, 7 Aug 2012 17:50:20 +0100 From: Mark Brown To: Sascha Hauer Cc: Matt Sealey , Robert Schwebel , Anton Vorontsov , Russell King , John Stultz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, Sascha Hauer Subject: Re: [PATCH 4/9] ASoC: imx: Don't use {en,dis}able_fiq() calls Message-ID: <20120807165019.GT16861@opensource.wolfsonmicro.com> References: <20120805230238.GA1663@lizard> <1344207819-3415-4-git-send-email-anton.vorontsov@linaro.org> <20120806154951.GQ16861@opensource.wolfsonmicro.com> <20120806193734.GA16199@opensource.wolfsonmicro.com> <20120806201609.GX25644@pengutronix.de> <20120806214121.GA26698@opensource.wolfsonmicro.com> <20120807063558.GE1451@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120807063558.GE1451@pengutronix.de> X-Cookie: You will be married within a year. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 21 On Tue, Aug 07, 2012 at 08:35:58AM +0200, Sascha Hauer wrote: > Nowadays the FIQ support is necessary only for AC97. The AC97 support in > the SSI unit is buggy: It does not allow you to select the slots you > want to receive. At least the wm9712 codec always sends (apart from the > stereo data) data in slot (I think it is) 12. You find this data mixed > in your audio stream. The FIQ driver skips this data to get a valid > audio stream. Right, any device with GPIO support will do this - it's how GPIO works in AC'97. > One other way to solve this would be to use dma here and to filter out > the data afterwards. Yup. That's probably more sane but also more work to implement. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/