Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031163Ab2HGW7A (ORCPT ); Tue, 7 Aug 2012 18:59:00 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:56461 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031020Ab2HGWpb (ORCPT ); Tue, 7 Aug 2012 18:45:31 -0400 From: Matt Sealey To: Linux ARM Kernel Mailing List Cc: Steev Klimaszewski , Linux Kernel Mailing List , Matt Sealey , Shawn Guo , Dave Martin , Anton Vorontsov , Mark Brown , Sascha Hauer Subject: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent CONFIG_THUMB2_KERNEL build breakage Date: Tue, 7 Aug 2012 17:45:13 -0500 Message-Id: <1344379514-30076-2-git-send-email-matt@genesi-usa.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1344379514-30076-1-git-send-email-matt@genesi-usa.com> References: <1344379514-30076-1-git-send-email-matt@genesi-usa.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 39 If i.MX SSI FIQ support is enabled then it is impossible to build a Thumb2 kernel image due to the code not being written with Thumb2 in mind (over-use of registers). In order not to break Thumb2 kernels, compile this as ARM. All the processors which require this support will run ARM code so there is no problem at runtime in doing this, even if it does produce a strange mix of code that may not be desired. In theory this should only be needed on configs based on imx_v4_v5_defconfig where CONFIG_THUMB2_KERNEL cannot be selected anyway since these SoCs do not have ARM cores capable of running Thumb2 code. This also makes rewriting the code as Thumb-compatible kind of redundant. But since one Eukrea board audio driver needs it, and there is an i.MX51 CPU module for this board, it gets pulled in for imx_v6_v7_defconfig too, making this a necessity. Signed-off-by: Matt Sealey --- arch/arm/plat-mxc/ssi-fiq.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/plat-mxc/ssi-fiq.S b/arch/arm/plat-mxc/ssi-fiq.S index 8397a2d..ac09af8 100644 --- a/arch/arm/plat-mxc/ssi-fiq.S +++ b/arch/arm/plat-mxc/ssi-fiq.S @@ -28,6 +28,7 @@ #define SSI_SIER_RFF0_EN (1 << 2) .text + .arm .global imx_ssi_fiq_start .global imx_ssi_fiq_end .global imx_ssi_fiq_base -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/