From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>,
        "'Dongjin Kim'" <Dongjin.Kim@agreeyamobility.net>
Cc: "'Dongjin Kim'" <tobetter@gmail.com>,
        "'Russell King'" <linux@arm.linux.org.uk>,
        "'Thomas Abraham'" <thomas.abraham@linaro.org>,
        "'Grant Likely'" <grant.likely@secretlab.ca>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1344366398-19022-1-git-send-email-dongjin.kim@agreeyamobility.net>
 <201208071938.26507.arnd@arndb.de>
 <A6A3B7488C419F488E5B13FFD03C08AD2F4372EB@SN2PRD0510MB370.namprd05.prod.outlook.com>
 <201208072029.08693.arnd@arndb.de>
In-reply-to: <201208072029.08693.arnd@arndb.de>
Subject: =?ks_c_5601-1987?B?UkU6IMi4vcU6IFtQQVRDSCAyLzRdIGFybS9kdHM6IGV4eQ==?=
	=?ks_c_5601-1987?B?bm9zNDogQWRkIERUUyBmaWxlcyBkZXJpdmVkIGZyb20gYw==?=
	=?ks_c_5601-1987?B?b21tb24gRXh5bm9zNA==?=
Date: Wed, 08 Aug 2012 11:08:54 +0900
Message-id: <0a3a01cd750a$c2e6a2b0$48b3e810$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=ks_c_5601-1987
Content-transfer-encoding: 7bit
Thread-index: Ac1021I8x/NFXhXeQqG+bq9k79zD5QALlpgQ
Content-language: ko
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1402
Lines: 45

Arnd Bergmann wrote:
> 
> On Tuesday 07 August 2012, Dongjin Kim wrote:
> > Hi,
> >
> > I didn't use -M and I couldn't see any difference with the it.
> > Did I make something wrong on that patch?
> 
> No, I think it's just git being less smart about file moves than I was
> hoping
> for. It might do the right thing if you do the patch in two steps:
> 
Yeah, in this case, git does not work just as we expected :-(

> 1. rename exynos4210.dtsi to exynos4.dtsi and add a one-line
> exynos4210.dtsi
> file that just includes exynos4.dtsi.
> 
> 2. do all the changes for moving contents back from exynos4.dtsi into
> exynos4210.dtsi and exynos4412.dtsi.
> 
> Not sure if it's worth it though.

Hehehe, but I did with separated commit as per your comment and it was ok,
then squashed, same...uhm...I think, we don't need to keep two commits
here...

> Your version is probably good enough
> if there are no tools to do a better job automatically.
> 
I agree with Arnd's opinion and I will review in detail soon.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/