Date: Wed, 8 Aug 2012 08:50:46 +0200
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: "'Tushar Behera'" <tushar.behera@linaro.org>,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        s.hauer@pengutronix.de, patches@linaro.org,
        Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] ARM: SAMSUNG: Fix compilation error with
 s3c2410_defconfig
Message-ID: <20120808065046.GA30832@avionic-0098.mockup.avionic-design.de>
References: <1344333546-16995-1-git-send-email-tushar.behera@linaro.org>
 <098f01cd7488$0d66d630$28348290$%kim@samsung.com>
 <5020F568.5020204@linaro.org>
 <0a2d01cd7500$53e26c50$fba744f0$%kim@samsung.com>
 <20120808061102.GA22417@avionic-0098.mockup.avionic-design.de>
 <0abe01cd752f$4f96ad80$eec40880$%kim@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="sm4nu43k4a2Rpi4c"
Content-Disposition: inline
In-Reply-To: <0abe01cd752f$4f96ad80$eec40880$%kim@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3682
Lines: 111


--sm4nu43k4a2Rpi4c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote:
> Thierry Reding wrote:
> >=20
> > On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote:
> > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-
> > samsung/Kconfig
> > > index 7aca31c..dcdfb77 100644
> > > --- a/arch/arm/plat-samsung/Kconfig
> > > +++ b/arch/arm/plat-samsung/Kconfig
> > > @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI
> > >
> > >  config S3C24XX_PWM
> > >  	bool "PWM device support"
> > > -	select HAVE_PWM
> > > +	select PWM
> > >  	help
> > >  	  Support for exporting the PWM timer blocks via the pwm device
> > >  	  system
> >=20
> > You could add
> >=20
> > 	select PWM_SAMSUNG
> >=20
> Well, the 'PWM_SAMSUNG' depends on 'PWM', so I think, it'd better to sele=
ct
> PWM_SAMSUNG for building pwm-samsung.c automatically when PWM is selected.
>=20
> > here to side-step the issue below.
> >=20
> > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > > index 8fc3808..34c8ec1 100644
> > > --- a/drivers/pwm/Kconfig
> > > +++ b/drivers/pwm/Kconfig
> > > @@ -59,7 +59,7 @@ config PWM_PXA
> > >
> > >  config PWM_SAMSUNG
> > >  	tristate "Samsung pwm support"
> > > -	depends on PLAT_SAMSUNG
> > > +	def_bool PLAT_SAMSUNG
> >=20
> > tristate and def_bool conflict, don't they? I think the easiest way to
>=20
> Yeah, your pointing out is correct, but in this case, it should be 'bool'
> not 'tristate' because the PWM driver cannot support module now.

Is there any reason why that is so? Looking at the driver it seems like
it should be easy to turn it into a module. I know that Jingoo (Cc'ed)
has been working on the driver and I've asked him the same question
already.

Anyway I don't want to force the issue, I just think you should consider
it.

> > solve this problem would be to add a default line, like so:
> >=20
> > 	default PLAT_SAMSUNG
> >=20
> > I've checked this with a s3c2410_defconfig and this causes PWM_SAMSUNG
> > to be selected =3Dy, which I guess is what you want.
> >=20
> How do you think following, just adding from original one?
>=20
> -	tristate "Samsung pwm support"
> +	bool "SAMSUNG PWM support"
>=20
> Thanks.

If you convert this to bool anyway, then maybe you can still use
def_bool:

	config PWM_SAMSUNG
		prompt "SAMSUNG PWM support" if PLAT_SAMSUNG
		def_bool PLAT_SAMSUNG

Any particular reason why you want "SAMSUNG" capitalized?

Thierry

--sm4nu43k4a2Rpi4c
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQIgxGAAoJEN0jrNd/PrOhOFEP/jR19b8ZJnplVNqlwZavVRbl
lLp3BKh5Z1L/CLancMJECgc3QW+PfD85H3wRy/xGP6Y+BTSnEc4LZPjc/KX+FFgW
WE0powgZrNJiYs/ZsVAx4H2FyUuE1Wui5pDzS0jL1uMqwj+5HUwYE/HJ4jnDY6gi
APL16EBbf1PQHuVwdFr9sDKHe6n+JMuMBMD614tHVlbCHn+PVNYThqcevBY0zq1j
ZxOiXU4ASOqocm34SIJEKnwRWO1Gxy7tjACUmiqPIykl2yyQPQhy7d6xhB4DPvXB
z+s79oQ3y8+jKWSDsE0N++828F7pOerhYrnke8xxRSU0wMwlY9dmHm/Yh8yFI99i
p7liblORzfYaQ2C99xdOPreF9MVPVG7NmEKlMO1OwKjl0wsXDsjEY5RwK3SvxbeD
PIBRED0Bdvm4tXw6ugfUftLXUL0cYqovaBu5kwEamITxoaN7iVz4oei9X7vVvldY
PmvlzoE3Bw1RjKzz9cfLkZ0ip1/32m8z3V57IjvCPt/6zvHM6H8pudsKwugNBWVS
EhnTfzOvUY6xNpRDzWhTPVHNzG3wutNZISRu4Pzcrl5JYRnG0W1l/T1ZxrktMMAQ
czKWzN8OqbNcmXQ6Zg9GXspv9/6zjpfggpkLT+HhhgnQGBOyFyREUToATYTGBe4o
3+mRzL0kZH4jc35tSeHx
=FrJc
-----END PGP SIGNATURE-----

--sm4nu43k4a2Rpi4c--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/