Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757452Ab2HHLjk (ORCPT ); Wed, 8 Aug 2012 07:39:40 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:65272 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825Ab2HHLjj (ORCPT ); Wed, 8 Aug 2012 07:39:39 -0400 Date: Wed, 8 Aug 2012 13:39:35 +0200 From: Thierry Reding To: Kukjin Kim Cc: "'Tushar Behera'" , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, patches@linaro.org, "'Jingoo Han'" Subject: Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Message-ID: <20120808113935.GA20963@avionic-0098.mockup.avionic-design.de> References: <1344333546-16995-1-git-send-email-tushar.behera@linaro.org> <098f01cd7488$0d66d630$28348290$%kim@samsung.com> <5020F568.5020204@linaro.org> <0a2d01cd7500$53e26c50$fba744f0$%kim@samsung.com> <20120808061102.GA22417@avionic-0098.mockup.avionic-design.de> <0abe01cd752f$4f96ad80$eec40880$%kim@samsung.com> <20120808065046.GA30832@avionic-0098.mockup.avionic-design.de> <0af001cd7550$1af66040$50e320c0$%kim@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: <0af001cd7550$1af66040$50e320c0$%kim@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:hWXwOnfZCojBI09hhR4nZGuEh5G6O0gEHWA31Sx1i01 kkla5oj1KHIVJ4xhQzwbLa/dWZM6pjYJtPvUntLD+iWiYGLZdn KekWaNMudXdxmm3JSzU6I3bIZNRmoR1ENbVd+Dd2NfvCIWVida swaudH5Ojb2mETkDER9jfPzbrFAzwnzWeUJQFvX8sEhiAQSxF4 1lBSm9KQ5rbmnc2Durqg8/5G2f2/VkqL52pK72deV8KE/erMO+ MRf36dXgdjyBLcsAsbEp5PtxGLQSc3++8jw88wezwS7KY8Mc6d ju8bB0fSEgi5eozhTPjfzbxzrqNs0dWNMKjuzF5M34+mIRFF0y pdMYzf5NHhYA5L/We292CfgZpbkTctDEUHN2iXpavLvgOe91qN OxAIA92pt5fGs4v8i/Ixy0kva716VXlkQU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2390 Lines: 67 --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > So, how about following? If PWM is selected on Samsung SoCs, the PWM_SAMS= UNG > will be selected automatically. Of course, it can be de-selected in kernel > menuconfig. Note that, I think, using 'bool ' and 'depends on ' > is more clear than 'prompt ["if" ]'. However if any your > preference here, please kindly let me know. >=20 > --- > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 8fc3808..c74d055 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -58,14 +58,12 @@ config PWM_PXA > will be called pwm-pxa. >=20 > config PWM_SAMSUNG > - tristate "Samsung pwm support" > + bool "Samsung PWM support" > depends on PLAT_SAMSUNG > + default y > help > Generic PWM framework driver for Samsung. > =20 > - To compile this driver as a module, choose M here: the module > - will be called pwm-samsung. > - > config PWM_TEGRA > tristate "NVIDIA Tegra PWM support" > depends on ARCH_TEGRA Acked-by: Thierry Reding --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQIk/3AAoJEN0jrNd/PrOhvxUQAIBt2ijCeYKWoSUh6Y3PT+5t HmCCkUyXfi6VNnKNDd5z8NNrO6PDdRw3QTAXbYJGoe32gH3ehPkKbE+SMvXmXduV dUaTkHCX9fGVwNNHdHF079E0tdJ+n0Kt6pbA4ktAA+0oORqK8LF6uDyPGyU8h7z6 QFl4TgKqBDgGRxTK1mbZwo9EaN5mwm5X3ZvXWpANFfSmF/HP8d/LlTKJ6j4N5Roc hecYq9b8ujvbHXvh/0Gi99Vdm0r4J0Q5wGM6ua3pITpU14y5BUpptkQuYKJ7Rn30 i8gD89NJt5zoahU4hblCmGb7bGyQQ4aFpN35sx+upPMIG3V87gH3W5bzu8DF4XMr 2D5MvsQhRmhwCaezbaa8Sobj74ifNIJhkEmnlr9TgiUE6OB6KNVj7YyRQ1VLx+Ku ubpajGjzaEaWjMiwmMUbqLHIHFiMUEVsHIyFJYXml8LPl4H6TmlUMGQx/bJENnGF Mlc2LCU9xTxPPbGNpLWKdNqtw3LZKWLgHCz7KCXrkS2xUGsg1EQ4778ZjAbjw7HO yZMPcSn3wbWiLzZu+qdu1btr8FUjnoR9A3mrRaB2FgdqW1O1kLBWpYArC+Gx5Dhr j7znpOB5EzmDEY+2aF+5glZL2aqGfj0M8fHtQSUU9DARe90gQvv3ByNS14UXRc2S B9Qyfj0u8ciuKBtYO7+3 =bc1g -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/