Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758243Ab2HHNDJ (ORCPT ); Wed, 8 Aug 2012 09:03:09 -0400 Received: from smtp2-v.fe.bosch.de ([139.15.237.6]:48438 "EHLO smtp2-v.fe.bosch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757805Ab2HHNDH (ORCPT ); Wed, 8 Aug 2012 09:03:07 -0400 Message-ID: <502262E4.9020303@de.bosch.com> Date: Wed, 8 Aug 2012 15:00:20 +0200 From: Dirk Behme Organization: Robert Bosch Car Multimedia GmbH User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Arnd Bergmann CC: "linux-arm-kernel@lists.infradead.org" , Sascha Hauer , "arm@kernel.org" , "linux-kernel@vger.kernel.org" , Shawn Guo Subject: Re: [PATCH 6/6] ARM: imx: gpmi-nand depends on mxs-dma References: <1344430493-5304-1-git-send-email-arnd@arndb.de> <1344430493-5304-7-git-send-email-arnd@arndb.de> In-Reply-To: <1344430493-5304-7-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.34.217.145] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2026 Lines: 55 On 08.08.2012 14:54, Arnd Bergmann wrote: > It is not currently possible to build the gpmi-nand driver without > also building the mxs-dma driver. Clarify this Kconfig and enable > both in the defconfig file so we can build it again with both enabled. > > drivers/built-in.o: In function `gpmi_dma_filter': > clk-fixed-factor.c:(.text+0xafc18): undefined reference to `mxs_dma_is_apbh' > make[1]: *** [vmlinux] Error 1 > make: *** [sub-make] Error 2 > > Signed-off-by: Arnd Bergmann > Cc: Shawn Guo > Cc: Sascha Hauer Acked-by: Dirk Behme Thanks Dirk > --- > arch/arm/configs/imx_v6_v7_defconfig | 1 + > drivers/mtd/nand/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index f725b96..3c9f32f 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=y > CONFIG_RTC_DRV_MXC=y > CONFIG_DMADEVICES=y > CONFIG_IMX_SDMA=y > +CONFIG_MXS_DMA=y > CONFIG_COMMON_CLK_DEBUG=y > # CONFIG_IOMMU_SUPPORT is not set > CONFIG_EXT2_FS=y > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 31bb7e5..8ca4176 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -480,7 +480,7 @@ config MTD_NAND_NANDSIM > > config MTD_NAND_GPMI_NAND > bool "GPMI NAND Flash Controller driver" > - depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) > + depends on MTD_NAND && MXS_DMA > help > Enables NAND Flash support for IMX23 or IMX28. > The GPMI controller is very powerful, with the help of BCH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/