Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758310Ab2HHNSA (ORCPT ); Wed, 8 Aug 2012 09:18:00 -0400 Received: from www.linutronix.de ([62.245.132.108]:58619 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758256Ab2HHNR7 (ORCPT ); Wed, 8 Aug 2012 09:17:59 -0400 Message-ID: <50226700.9000606@linutronix.de> Date: Wed, 08 Aug 2012 15:17:52 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: Oleg Nesterov CC: linux-kernel@vger.kernel.org, x86@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Roland McGrath , Srikar Dronamraju , Ananth N Mavinakaynahalli , stan_shebs@mentor.com Subject: Re: [PATCH 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step References: <1344355952-2382-1-git-send-email-bigeasy@linutronix.de> <1344355952-2382-3-git-send-email-bigeasy@linutronix.de> <20120808125709.GA4504@redhat.com> In-Reply-To: <20120808125709.GA4504@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 666 Lines: 23 On 08/08/2012 02:57 PM, Oleg Nesterov wrote: >> +static int insn_changes_flags(struct arch_uprobe *auprobe) >> +{ >> + /* popf reads flags from stack */ >> + if (auprobe->insn[0] == 0x9d) >> + return 1; > > Ah, somehow I didn't think about this before. > > ->insn[0] doesn't look right, we should skip the prefixes. Why? I tried 'lock popf' and I got invalid instruction. The same for 'rep popf'. > Oleg. > Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/