Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438Ab2HHOGX (ORCPT ); Wed, 8 Aug 2012 10:06:23 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:50319 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755206Ab2HHOGU (ORCPT ); Wed, 8 Aug 2012 10:06:20 -0400 Date: Wed, 8 Aug 2012 16:06:38 +0200 From: Daniel Vetter To: Tomasz Stanislawski Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Pawel Osciak , Greg Kroah-Hartman , Jerome Glisse , Vinod Koul , Kyungmin Park , Rob Landley , Daniel Vetter , Alex Deucher , Rob Clark , Dan Williams , Marek Szyprowski , Sumit Semwal , linux-media@vger.kernel.org Subject: Re: [PATCH] dma-buf: add reference counting for exporter module Message-ID: <20120808140638.GK5490@phenom.ffwll.local> Mail-Followup-To: Tomasz Stanislawski , Laurent Pinchart , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Pawel Osciak , Greg Kroah-Hartman , Jerome Glisse , Vinod Koul , Kyungmin Park , Rob Landley , Alex Deucher , Rob Clark , Dan Williams , Marek Szyprowski , Sumit Semwal , linux-media@vger.kernel.org References: <50223CC5.9060007@samsung.com> <1404275.atroogfRqe@avalon> <50226F46.3080800@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50226F46.3080800@samsung.com> X-Operating-System: Linux phenom 3.4.0-rc3+ User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1885 Lines: 51 On Wed, Aug 08, 2012 at 03:53:10PM +0200, Tomasz Stanislawski wrote: > Hi Laurent, > > On 08/08/2012 03:35 PM, Laurent Pinchart wrote: > > Hi Tomasz, > > > > Thanks for the patch. > > > > On Wednesday 08 August 2012 12:17:41 Tomasz Stanislawski wrote: > >> This patch adds reference counting on a module that exports dma-buf and > >> implements its operations. This prevents the module from being unloaded > >> while DMABUF file is in use. > >> > >> Signed-off-by: Tomasz Stanislawski > >> --- > >> Documentation/dma-buf-sharing.txt | 3 ++- > >> drivers/base/dma-buf.c | 10 +++++++++- > >> drivers/gpu/drm/exynos/exynos_drm_dmabuf.c | 1 + > >> drivers/gpu/drm/i915/i915_gem_dmabuf.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_prime.c | 1 + > >> drivers/gpu/drm/radeon/radeon_prime.c | 1 + > >> drivers/staging/omapdrm/omap_gem_dmabuf.c | 1 + > >> include/linux/dma-buf.h | 2 ++ > >> 8 files changed, 18 insertions(+), 2 deletions(-) > >> > [snip] > > >> @@ -96,6 +98,7 @@ struct dma_buf *dma_buf_export(void *priv, const struct > >> dma_buf_ops *ops, struct file *file; > >> > >> if (WARN_ON(!priv || !ops > >> + || !ops->owner > > Thank you for spotting this. > I didn'y know that try_get_module returned true is module was NULL. > > BTW. Is it worth to add ".owner = THIS_MODULE," to all dma_buf > exporters in this patch? Yeah, I think that makes sense. Otherwise it might get lost somewhere, i.e. you can smash my Ack on this. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/