Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759283Ab2HHUqt (ORCPT ); Wed, 8 Aug 2012 16:46:49 -0400 Received: from exout101.netflix.com ([69.53.237.162]:6394 "EHLO exout103.netflix.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759163Ab2HHUqs (ORCPT ); Wed, 8 Aug 2012 16:46:48 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024;d=netflix.com; h=from:to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; b=Mp4iCqRWenWQZYm2LX5ICCq0fP2p/cWwmsLNiHtkvpShpRj9jNUY60RldLuMbezeqGiLs4zT Ow1Q5kpEVc5lpfaJmElP+LyQ1Rz61arB/1E29Qy82l1vRC/6qc5zZDfHHgE6s5mihTFgPILP oXRb0tvcxpEzu85evw2u0+gskIg= From: Wesley Miaw To: Milan Broz CC: Mikulas Patocka , device-mapper development , Alasdair Kergon , "msb@google.com" , "linux-kernel@vger.kernel.org" , =?Windows-1252?Q?Will_Drewry=99?= Subject: Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7) Thread-Topic: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7) Thread-Index: AQHNdZLjOIWAIbPp80KsaTGNtIwdlpdQXnkLgAB5j4A= Date: Wed, 8 Aug 2012 20:46:46 +0000 Message-ID: References: <8893CF66-2E2C-4D8F-9239-E38BE55716AE@netflix.com> <5022CC99.30103@redhat.com> In-Reply-To: <5022CC99.30103@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.2.229.146] Content-Type: multipart/signed; boundary="Apple-Mail=_BB6D1B9A-301B-46F7-BA19-4C8C058D4648"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2335 Lines: 62 --Apple-Mail=_BB6D1B9A-301B-46F7-BA19-4C8C058D4648 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > On 08/08/2012 08:46 PM, Mikulas Patocka wrote: >=20 >> The problem with the patch is that it changes interface to the = userspace=20 >> tool. The userspace tool veritysetup already exists in recent = cryptsetup=20 >> package, so we can't change the interface - you should change the = patch so=20 >> that the starting data block is the last argument and the argument is=20= >> optional - so that it is compatible with the existing userspace too. >=20 > yes. Please never change interface without at least increasing target = version. >=20 > I have to add userspace support as well to veritysetup and we need a = way > how to detect that option is supported by running kernel. Understood. Thank you for the feedback. I will attempt a new patch = version which addresses these issues. I also found that I did not = correct the last-block boundary check so I will re-submit my patch with = that as well. I did modify veritysetup on my own so the format and verify commands = will work with regular files on disk instead of having to mount through = loop devices. -- Wesley Miaw= --Apple-Mail=_BB6D1B9A-301B-46F7-BA19-4C8C058D4648 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) iQEcBAEBAgAGBQJQItA2AAoJELoPFVk1ivvRshUH/ig/0hogLn/utO1+ubjgW/Fd oRt8iaYaAAz9i6ufv6gK50RCT21KGd+qB9/83wKEr0a8uXmTm14z18i6GZCV3FlR 1cT8/elEvBgWWCyd3X5zRewYS45fgs47Xw2PpkUG4BOwT5MFyj9R5sdsFKTpsnNr P74QQ60GY3xIoFijNNJ+GRqQCzIo7Scd5i/1iv3sjJDF9ONCRmZezBU4FmqO1jNQ qsoN4Az5GOLNmH+GJAX8D0pc7AqaFKO71Ad9JOjT8scWN8igoNH+dqyTJdStr4j7 fUw7r/yCM1d7S63eFsrKXolEeBMDr527tcbqtipdAcaCIHn/jlMaBS4QZoZvtsw= =RPrr -----END PGP SIGNATURE----- --Apple-Mail=_BB6D1B9A-301B-46F7-BA19-4C8C058D4648-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/