Date: Wed, 8 Aug 2012 23:19:21 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [PATCH 18/41] TTY: pty, switch to tty_alloc_driver
Message-ID: <20120808231921.1f60351c@pyramind.ukuu.org.uk>
In-Reply-To: <5022C804.2070104@suse.cz>
References: <1344368886-24033-1-git-send-email-jslaby@suse.cz>
	<1344368886-24033-19-git-send-email-jslaby@suse.cz>
	<20120808163757.28a28df1@bob.linux.org.uk>
	<5022C804.2070104@suse.cz>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII=
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 16

> this and 19/41. The merge with DEVPTS_MEM (the termios case) needs
> devpts_kill_index to be moved from tty_release to
> pty_driver->ops->cleanup/shutdown, but I don't feel comfortable to do it
> now since it needs some testing. So I would add this to TODO and will
> send it after the next merge window. If I understood your point correctly?

That seems sensible - its on my list to sort as well. We don't need to
allocate some of the pointer arrays for many of the drivers (anything
which doesn't save termios state for example)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/