Message-ID: <5022EA1E.3010306@fb.com>
Date: Wed, 8 Aug 2012 15:37:18 -0700
From: Arun Sharma <asharma@fb.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: <linux-kernel@vger.kernel.org>
CC: Ingo Molnar <mingo@elte.hu>, Arnaldo Carvalho de Melo <acme@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>,
        Namhyung Kim <namhyung.kim@lge.com>, Tom Zanussi <tzanussi@gmail.com>,
        <linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)
References: <1333172421-6775-2-git-send-email-asharma@fb.com> <4F769976.3070203@fb.com> <5022BB0E.8050706@fb.com>
In-Reply-To: <5022BB0E.8050706@fb.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 830
Lines: 25

On 8/8/12 12:16 PM, Arun Sharma wrote:

>     and therefore breaks the invariant period == period_self
>     in the default mode (no sort inclusive).


hist_entry__decay() also needs an update to maintain the invariant.

--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -138,6 +138,7 @@ static void hist_entry__add_cpumode_period(struct 
hist_entry *he,
  static void hist_entry__decay(struct hist_entry *he)
  {
         he->period = (he->period * 7) / 8;
+       he->period_self = (he->period_self * 7) / 8;
         he->nr_events = (he->nr_events * 7) / 8;
  }

  -Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/