Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758200Ab2HINta (ORCPT ); Thu, 9 Aug 2012 09:49:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58851 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756179Ab2HINt2 (ORCPT ); Thu, 9 Aug 2012 09:49:28 -0400 From: Mel Gorman To: Linux-MM Cc: Rik van Riel , Minchan Kim , Jim Schutt , LKML , Mel Gorman Subject: [PATCH 1/5] mm: compaction: Update comment in try_to_compact_pages Date: Thu, 9 Aug 2012 14:49:21 +0100 Message-Id: <1344520165-24419-2-git-send-email-mgorman@suse.de> X-Mailer: git-send-email 1.7.9.2 In-Reply-To: <1344520165-24419-1-git-send-email-mgorman@suse.de> References: <1344520165-24419-1-git-send-email-mgorman@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 37 The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area. Signed-off-by: Mel Gorman Reviewed-by: Rik van Riel Reviewed-by: Minchan Kim --- mm/compaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index b39ede1..95ca967 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -759,11 +759,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, struct zone *zone; int rc = COMPACT_SKIPPED; - /* - * Check whether it is worth even starting compaction. The order check is - * made because an assumption is made that the page allocator can satisfy - * the "cheaper" orders without taking special steps - */ + /* Check if the GFP flags allow compaction */ if (!order || !may_enter_fs || !may_perform_io) return rc; -- 1.7.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/