Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031066Ab2HIPEV (ORCPT ); Thu, 9 Aug 2012 11:04:21 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:65477 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030965Ab2HIPEB (ORCPT ); Thu, 9 Aug 2012 11:04:01 -0400 MIME-Version: 1.0 X-Originating-IP: [76.119.162.148] In-Reply-To: <1344522472.28967.936.camel@edumazet-glaptop> References: <50215A7E.8000701@linaro.org> <1344462889.28967.328.camel@edumazet-glaptop> <5022FD9A.4020603@schaufler-ca.com> <1695034.0lrQgQPOMT@sifl> <1344522472.28967.936.camel@edumazet-glaptop> Date: Thu, 9 Aug 2012 11:04:00 -0400 Message-ID: Subject: Re: NULL pointer dereference in selinux_ip_postroute_compat From: Paul Moore To: Eric Dumazet Cc: Casey Schaufler , Eric Paris , John Stultz , "Serge E. Hallyn" , lkml , James Morris , selinux@tycho.nsa.gov, Eric Dumazet , john.johansen@canonical.com, LSM Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 28 On Thu, Aug 9, 2012 at 10:27 AM, Eric Dumazet wrote: > On Thu, 2012-08-09 at 09:30 -0400, Paul Moore wrote: > >> In the case of a TCP syn-recv and timewait ACK things are a little less clear. >> Eric (Dumazet), it looks like we have a socket in tcp_v4_reqsk_send_ack() and >> tcp_v4_timewait_ack(), any reason why we can't propagate the socket down to >> ip_send_unicast_reply()? >> > > timewait 'sockets' are not full blown sockets. > > We need a socket (well, a good part of it) to build the IP frame and > send it. Yes, of course you're right. Ideally we need a better solution here from a LSM perspective, but I don't think this should hold up the fix as the labeling was broken even before the postroute_compat() code broke. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/