Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759181Ab2HIS46 (ORCPT ); Thu, 9 Aug 2012 14:56:58 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:6432 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759045Ab2HIS45 (ORCPT ); Thu, 9 Aug 2012 14:56:57 -0400 Message-ID: <1344538611.2593.4.camel@bwh-desktop.uk.solarflarecom.com> Subject: Re: [PATCH] net: add new QCA alx ethernet driver From: Ben Hutchings To: Steven Rostedt CC: Joe Perches , "Ren, Cloud" , David Miller , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , "Huang, Xiong" , "hao-ran.liu@canonical.com" , "Rodriguez, Luis" Date: Thu, 9 Aug 2012 19:56:51 +0100 In-Reply-To: <1344526098.6935.44.camel@gandalf.stny.rr.com> References: <6349D7A510622448B1BA0967850A8438013692CA@NASANEXD02D.na.qualcomm.com> <1344485382.2024.9.camel@joe2Laptop> <6349D7A510622448B1BA0967850A843801369364@NASANEXD02D.na.qualcomm.com> <20120808.231804.12694947300243733.davem@davemloft.net> <6349D7A510622448B1BA0967850A8438013693DD@NASANEXD02D.na.qualcomm.com> <20120809145454.GA21195@home.goodmis.org> <1344525758.3165.8.camel@joe2Laptop> <1344526098.6935.44.camel@gandalf.stny.rr.com> Organization: Solarflare Communications Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.17.20.137] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 35 On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote: > On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: > > > Yes, I sent signed-off patches to their original RFC submission > > (back last year?). To me, this single large patch is like a > > snapshot of a git tree and not all contributors to that git > > tree should be noted as signers of the entire thing. > > Ouch, that looks like we are losing all history. > > One large patch should not be submitted. If it was developed in steps, > then it is best to show those steps when they are incorporated into the > Linux repository. > > Sure, the patches may be reworked and folded together where appropriate, > but when I read "this single large patch is like a snapshot of a git > tree", that right there is a red flag. I don't think this has ever been a requirement for new drivers. The alterations to the description of atl1c ought to be broken out as a separate patch, though. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/