Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759245Ab2HITI1 (ORCPT ); Thu, 9 Aug 2012 15:08:27 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:58732 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185Ab2HITI0 (ORCPT ); Thu, 9 Aug 2012 15:08:26 -0400 Date: Thu, 9 Aug 2012 16:08:19 -0300 From: Arnaldo Carvalho de Melo To: Alan Cox Cc: David Ahern , Frederic Weisbecker , LKML , Ingo Molnar , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 1/3] perf tools: Initial bash completion support Message-ID: <20120809190819.GD4084@infradead.org> References: <1344522713-27951-1-git-send-email-fweisbec@gmail.com> <1344522713-27951-2-git-send-email-fweisbec@gmail.com> <20120809163515.GA4084@infradead.org> <5023E7F3.8090701@gmail.com> <20120809171419.GC4084@infradead.org> <20120809192706.625671f0@pyramind.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120809192706.625671f0@pyramind.ukuu.org.uk> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 30 Em Thu, Aug 09, 2012 at 07:27:06PM +0100, Alan Cox escreveu: > > > 3rd patch should fix this. > > > > Huh? The problem is not /etc/bash_completion.d/ not existing, it exists, > > its just that I'm not using sudo nor installing as root, this new bash > > completion file is the only one that is being installed on the root > > filesystem, all others are in ~acme/ > > And even with permissions it might not have the right security labels on > a well secured box. > > It's a neat little script (or once its been properly security audited > will be) but IMHO it belongs in the distro bash script packages. Yeah, I think we can keep it in the kernel sources and then send new versions to the bash-completion-devel@lists.alioth.debian.org guys. To test I just did: ln -s ~/etc/bash_completion.d/perf ~/.bash_completion Fr?d?ric, I merged your patches as-is and pushed them to my perf/core branch, thanks! - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/