Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757988Ab2HJITN (ORCPT ); Fri, 10 Aug 2012 04:19:13 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:33012 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757841Ab2HJITD (ORCPT ); Fri, 10 Aug 2012 04:19:03 -0400 MIME-Version: 1.0 In-Reply-To: <20120809202054.GA24503@avionic-0098.mockup.avionic-design.de> References: <1343044770-6591-1-git-send-email-thierry.reding@avionic-design.de> <20120809202054.GA24503@avionic-0098.mockup.avionic-design.de> Date: Fri, 10 Aug 2012 10:19:02 +0200 Message-ID: Subject: Re: [PATCH v2] gpio: Add Avionic Design N-bit GPIO expander support From: Linus Walleij To: Thierry Reding Cc: Grant Likely , Arnd Bergmann , linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Linus Walleij , Rob Herring , Wolfram Sang , Russell King - ARM Linux Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 29 On Thu, Aug 9, 2012 at 10:20 PM, Thierry Reding wrote: > On Sun, Jul 29, 2012 at 07:13:57PM +0200, Linus Walleij wrote: >> > + client->irq = irq_of_parse_and_map(client->dev.of_node, 0); >> > + if (client->irq == NO_IRQ) >> >> Just if (!client->irq) since NO_IRQ is 0 nowadays. > > At the risk of seeming pedantic, NO_IRQ is in fact quite often not 0. No. A year back, yes, but not anymore. We went to great lengths in the ARM architecture to ensure NO_IRQ is *always 0. Russell spent a lot of time on this. Consult the following article on LWN: http://lwn.net/Articles/470820/ Then grep your gitlog and you'll see we got rid of it from ARM. If this driver is for some other arch like openrisc I might accept it but please reconsider. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/