Date: Fri, 10 Aug 2012 11:55:36 +0200
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 2/2] pwm: core: Fix coding style issues
Message-ID: <20120810095536.GA20314@avionic-0098.mockup.avionic-design.de>
References: <1344573730-21907-1-git-send-email-sachin.kamat@linaro.org>
 <1344573730-21907-2-git-send-email-sachin.kamat@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj"
Content-Disposition: inline
In-Reply-To: <1344573730-21907-2-git-send-email-sachin.kamat@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2264
Lines: 64


--9amGYk9869ThD9tj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 10, 2012 at 10:12:10AM +0530, Sachin Kamat wrote:
> Fixes the following:
> WARNING: line over 80 characters
> ERROR: spaces required around that ':' (ctx:VxW)
> WARNING: Prefer pr_warn(... to pr_warning(...
>=20
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/pwm/core.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index efc20f8..929be13 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -130,7 +130,7 @@ static int pwm_device_request(struct pwm_device *pwm,=
 const char *label)
>  }
> =20
>  static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc,
> -					      const struct of_phandle_args *args)
> +					     const struct of_phandle_args *args)
>  {
>  	struct pwm_device *pwm;
> =20

Can this hunk be removed, please? I think aligning the arguments is more
useful than respecting the 80-columns limit.

Thierry

--9amGYk9869ThD9tj
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQJNqYAAoJEN0jrNd/PrOhIBAP/2mAJgQ42M1GAOSJIdHMnq0t
sN2l1+M4g6aQqOpkALxfpNBFn5GBJ9E3/fHPS4+SlKi4cqqbB62VuXTkwmYuUrBd
KDnpCnj0CFBay221OGH3DvUcqwYCzrnjZXvV6ev59Npb0Y8zMKda1msGv2ELXnM0
dZBD2ZmdQSkxuGo+25q/v36e3L3FT5VBY+vLClZbHng9MGpCkpkNuhrpjBL7Lk4v
0s9lab+zb+H97nocAIWacdKNPUW4aqveiEdmDMUn2pG5v6seD+4G0L3ZMs1LAPae
rhEeWYeNWBmmHeIy0eGPgYwhtLyGsDs+LSerLB5K3vGj5kp0rMc39yHLFE4CFL8C
08m1R3AP7LXg+FKesl1GPECBU1367grG5mx7ALmyo7Yet7HwSRR5ov2Lvaxzo8VF
RzZPSoWF+gu9+kmk0cbuTtFzPp9QEeJvCqivmDYqzWDwGMX6ZgoMVu3zLVaxc/6s
yxJ21xXhaRcc7iP0FM942TkD84EASzYDmefrk1eak9XxF4rmI4HKT43tlebbB68/
ErSbLOKIwrcbjuAFAvPgpuCwOAk4h6v7hljEUH4cOVWXPjAD7cdBldkeQphQVMAV
A936eCuXLEnXD/w+taziqc/rCnf4SUQ+/U7+JO5bSCKPQCiRpziJWhszrwUipM99
YiHNK6aVGRSlio7yxL1G
=REgP
-----END PGP SIGNATURE-----

--9amGYk9869ThD9tj--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/