Date: Fri, 10 Aug 2012 12:58:18 +0200
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Joe Perches <joe@perches.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>, linux-kernel@vger.kernel.org,
        patches@linaro.org
Subject: Re: [PATCH 2/2] pwm: core: Fix coding style issues
Message-ID: <20120810105818.GA19457@avionic-0098.mockup.avionic-design.de>
References: <1344573730-21907-1-git-send-email-sachin.kamat@linaro.org>
 <1344573730-21907-2-git-send-email-sachin.kamat@linaro.org>
 <20120810095536.GA20314@avionic-0098.mockup.avionic-design.de>
 <CAK9yfHwmfW9K9jBfJJXr5S1nJOsetedkEQ96Rh4DT_zvOGr4eQ@mail.gmail.com>
 <20120810100233.GA1503@avionic-0098.mockup.avionic-design.de>
 <CAK9yfHxXEBecVbiMyBKA_sHfzA1evCYeV9W66McUqZ67f2q3hA@mail.gmail.com>
 <1344595893.2338.6.camel@joe2Laptop>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv"
Content-Disposition: inline
In-Reply-To: <1344595893.2338.6.camel@joe2Laptop>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2952
Lines: 81


--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 10, 2012 at 03:51:33AM -0700, Joe Perches wrote:
> On Fri, 2012-08-10 at 15:34 +0530, Sachin Kamat wrote:
> > On 10 August 2012 15:32, Thierry Reding
> > <thierry.reding@avionic-design.de> wrote:
> > > On Fri, Aug 10, 2012 at 03:29:08PM +0530, Sachin Kamat wrote:
> > >> On 10 August 2012 15:25, Thierry Reding
> > >> <thierry.reding@avionic-design.de> wrote:
> > >> > On Fri, Aug 10, 2012 at 10:12:10AM +0530, Sachin Kamat wrote:
> > >> >> Fixes the following:
> > >> >> WARNING: line over 80 characters
> > >> >> ERROR: spaces required around that ':' (ctx:VxW)
> > >> >> WARNING: Prefer pr_warn(... to pr_warning(...
> []
> > >> >> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> []
> > >> >> @@ -130,7 +130,7 @@ static int pwm_device_request(struct pwm_devi=
ce *pwm, const char *label)
> > >> >>  }
> > >> >>
> > >> >>  static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *p=
c,
> > >> >> -                                           const struct of_phand=
le_args *args)
> > >> >> +                                          const struct of_phandl=
e_args *args)
> > >> >>  {
>=20
> Another way to write this is to put the return type on a
> separate line like:
>=20
> type
> func(args to 80,
>      more args aligned to open paren...)
>=20
> for this case:
>=20
> static struct pwm_device *
> of_pwm_simple_xlate(struct pwm_chip *pc, const struct of_phandle_args *ar=
gs)

I was under the impression that the CodingStyle explicitly said not to
do this, but I've just checked and I couldn't find any mention of the
return type placement.

Sachin: Can you fix the warning as Joe suggested and resend the patch?

Thierry

--ZGiS0Q5IWpPtfppv
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQJOlKAAoJEN0jrNd/PrOhFWIP/1arvoKMV8SswAsAv4NhxFpH
QQ9rTFBm4tA5HelWP50kTfPcDS9N7LJA1rn0JLyf40W1/kW5Atd7rIIcpuWjzpSQ
nZxJ2+M1TN/M9QVt1QCHnk/ifEwWNScQFpZPzMWeMUdM6Twn7wF3A/CPABWrk8Zq
It9lg0YWdZcGcDgvxcWtWdp8wXp7y8hbmvkBrmcl4XRCuWciEXoV+Zi/fDPCeWeB
/45QBT40uywcqYJZ3ykkNbHZrPwqELBEa+mNJlTCTxgtwodEEtYXiTD1WFbElzXG
55vHMIAVo+C8Q/XIuO37RZRHc/Uz9l6dO8iiCMdaZJY6wh0vbJsD6bmXSE3k3kVX
/cN93/VPH8Pvle285ibi4eNFXLBCLhPex/1Cl9h3Kw/m6vyDjr6YhvaUTafQSz9D
z6b9mGgAY8bn9hTv6DG5QzIGR+1BlcYWkJj6Z+dbEa2xnhMsgjiyyGrI7yrlcWC0
g1L4n6mKdgOJ5ekDbvjFrU3LPOhIj9eZ0PqUZK1WNUwJyUmx7HNfcNDIcOqRmTf9
5wxeYTRxFJAoiRbSkQAiF4iOU1yK2KLlOgQqxt33EukrUrC220GZL1Qm5BpYZmeP
PJ2CNli0UhTEHpo3aj5icetIpO1eRhhV3ZWR7cByS5gTIB7KCnEbogNhmN4dqzND
CXlGiafZfJKFtsubiqnw
=AAVj
-----END PGP SIGNATURE-----

--ZGiS0Q5IWpPtfppv--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/