Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760211Ab2HJLCT (ORCPT ); Fri, 10 Aug 2012 07:02:19 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:38557 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760193Ab2HJLCP (ORCPT ); Fri, 10 Aug 2012 07:02:15 -0400 MIME-Version: 1.0 In-Reply-To: <20120810105818.GA19457@avionic-0098.mockup.avionic-design.de> References: <1344573730-21907-1-git-send-email-sachin.kamat@linaro.org> <1344573730-21907-2-git-send-email-sachin.kamat@linaro.org> <20120810095536.GA20314@avionic-0098.mockup.avionic-design.de> <20120810100233.GA1503@avionic-0098.mockup.avionic-design.de> <1344595893.2338.6.camel@joe2Laptop> <20120810105818.GA19457@avionic-0098.mockup.avionic-design.de> Date: Fri, 10 Aug 2012 16:32:13 +0530 Message-ID: Subject: Re: [PATCH 2/2] pwm: core: Fix coding style issues From: Sachin Kamat To: Thierry Reding Cc: Joe Perches , linux-kernel@vger.kernel.org, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2067 Lines: 55 On 10 August 2012 16:28, Thierry Reding wrote: > On Fri, Aug 10, 2012 at 03:51:33AM -0700, Joe Perches wrote: >> On Fri, 2012-08-10 at 15:34 +0530, Sachin Kamat wrote: >> > On 10 August 2012 15:32, Thierry Reding >> > wrote: >> > > On Fri, Aug 10, 2012 at 03:29:08PM +0530, Sachin Kamat wrote: >> > >> On 10 August 2012 15:25, Thierry Reding >> > >> wrote: >> > >> > On Fri, Aug 10, 2012 at 10:12:10AM +0530, Sachin Kamat wrote: >> > >> >> Fixes the following: >> > >> >> WARNING: line over 80 characters >> > >> >> ERROR: spaces required around that ':' (ctx:VxW) >> > >> >> WARNING: Prefer pr_warn(... to pr_warning(... >> [] >> > >> >> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c >> [] >> > >> >> @@ -130,7 +130,7 @@ static int pwm_device_request(struct pwm_device *pwm, const char *label) >> > >> >> } >> > >> >> >> > >> >> static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc, >> > >> >> - const struct of_phandle_args *args) >> > >> >> + const struct of_phandle_args *args) >> > >> >> { >> >> Another way to write this is to put the return type on a >> separate line like: >> >> type >> func(args to 80, >> more args aligned to open paren...) >> >> for this case: >> >> static struct pwm_device * >> of_pwm_simple_xlate(struct pwm_chip *pc, const struct of_phandle_args *args) > > I was under the impression that the CodingStyle explicitly said not to > do this, but I've just checked and I couldn't find any mention of the > return type placement. > > Sachin: Can you fix the warning as Joe suggested and resend the patch? > > Thierry Sure. Thanks for the tip Joe. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/