Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754952Ab2HJM3L (ORCPT ); Fri, 10 Aug 2012 08:29:11 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:60970 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044Ab2HJM3G (ORCPT ); Fri, 10 Aug 2012 08:29:06 -0400 Date: Fri, 10 Aug 2012 13:29:03 +0100 From: Mark Brown To: Axel Lin Cc: Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators Message-ID: <20120810122903.GJ24328@opensource.wolfsonmicro.com> References: <1344562353.2996.1.camel@phoenix> <20120810100547.GG24328@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: Be different: conform. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 800 Lines: 17 On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: > 2012/8/10 Mark Brown : > > We should be failing to register these regulators in the first place, or > > at least complaining extremely loudly about them. > Oh. My original intention is to prevent using list_voltage() to read > voltage regulators for the case "n_voltages > 1" in case of both get_voltage > and get_voltage_sel are not implemented. Yes, I see the intention - what I'm saying is that a regulator like that makes no sense in the first place. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/