Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636Ab2HJMlQ (ORCPT ); Fri, 10 Aug 2012 08:41:16 -0400 Received: from gate.crashing.org ([63.228.1.57]:53918 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099Ab2HJMlI convert rfc822-to-8bit (ORCPT ); Fri, 10 Aug 2012 08:41:08 -0400 Subject: Re: [PATCH] powerpc/smp: Do not disable IPI interrupts during suspend Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <20120802100418.GA13777@localhost.localdomain> Date: Fri, 10 Aug 2012 07:40:19 -0500 Cc: Zhao Chenhui , "linuxppc-dev@lists.ozlabs.org list" , "linux-kernel@vger.kernel.org list" , Li Yang Content-Transfer-Encoding: 8BIT Message-Id: <1C2FF4B5-3F3C-4A9D-941D-A4BC4F5C95DE@kernel.crashing.org> References: <1342788421-27648-1-git-send-email-chenhui.zhao@freescale.com> <5028672F-1873-4E45-AA23-4CA9F191BE77@kernel.crashing.org> <1343427631.21647.1.camel@pasglop> <20120802100418.GA13777@localhost.localdomain> To: Benjamin Herrenschmidt X-Mailer: Apple Mail (2.1278) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1480 Lines: 43 On Aug 2, 2012, at 5:04 AM, Zhao Chenhui wrote: > On Sat, Jul 28, 2012 at 08:20:31AM +1000, Benjamin Herrenschmidt wrote: >> On Fri, 2012-07-27 at 16:58 -0500, Kumar Gala wrote: >>> On Jul 20, 2012, at 7:47 AM, Zhao Chenhui wrote: >>> >>>> During suspend, all interrupts including IPI will be disabled. In this case, >>>> the suspend process will hang in SMP. To prevent this, pass the flag >>>> IRQF_NO_SUSPEND when requesting IPI irq. >>>> >>>> Signed-off-by: Zhao Chenhui >>>> Signed-off-by: Li Yang >>>> --- >>>> arch/powerpc/kernel/smp.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> BenH, >>> >>> Can you ack? >> >> No I'll merge it but not until it's been in next for a bit unless you >> have some strong emergency there, it's on my mental list of things to >> shovel into next after rc1. >> >> Curiosity: didn't we use to disable all non-boot CPUs on suspend ? >> >> Cheers, >> Ben. > > Yes, we disabled all non-boot CPUs on suspend by calling disable_nonboot_cpus(). > The disable_nonboot_cpus() needs IPIs to work. But prior to > calling disable_nonboot_cpus(), the IPIs are disabled in dpm_suspend_noirq(). > > -Chenhui Benh, Ack? - k-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/