Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758806Ab2HJRtm (ORCPT ); Fri, 10 Aug 2012 13:49:42 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:42704 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754746Ab2HJRtk (ORCPT ); Fri, 10 Aug 2012 13:49:40 -0400 MIME-Version: 1.0 In-Reply-To: <20120810062829.GA4546@mwanda> References: <1343141382-31087-1-git-send-email-benchan@chromium.org> <20120810062829.GA4546@mwanda> From: Ben Chan Date: Fri, 10 Aug 2012 10:49:19 -0700 X-Google-Sender-Auth: fL55-qqQ0RN-dfJFGjUZl9Ul0-Q Message-ID: Subject: Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init To: Dan Carpenter Cc: "devendra.aaru" , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 29 Hi Dan, I manually walked through the driver code and spotted the issue. But this morning I was able to get an extra module to verify my patch on hardware. I tested the following patterns using two identical modules, and checked the creation/destruction/ref_cnt of wm_event: - insert module A, remove A - insert A, insert B, remove A, remove B - insert A, insert B, remove B, remove A - insert A, insert B, remove A, remove B - insert A, insert B, remove B, insert B, remove B, remove A Thanks, Ben On Thu, Aug 9, 2012 at 11:28 PM, Dan Carpenter wrote: > Ben, I'm confused. Do you have a way to test this, or are you just > doing manual review? > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/