Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758212Ab2HKCXQ (ORCPT ); Fri, 10 Aug 2012 22:23:16 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:57582 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755222Ab2HKCXP (ORCPT ); Fri, 10 Aug 2012 22:23:15 -0400 MIME-Version: 1.0 Reply-To: axel.lin@gmail.com In-Reply-To: <20120810122903.GJ24328@opensource.wolfsonmicro.com> References: <1344562353.2996.1.camel@phoenix> <20120810100547.GG24328@opensource.wolfsonmicro.com> <20120810122903.GJ24328@opensource.wolfsonmicro.com> From: Axel Lin Date: Sat, 11 Aug 2012 10:22:54 +0800 Message-ID: Subject: Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 35 2012/8/10 Mark Brown : > On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: >> 2012/8/10 Mark Brown : > >> > We should be failing to register these regulators in the first place, or >> > at least complaining extremely loudly about them. > >> Oh. My original intention is to prevent using list_voltage() to read >> voltage regulators for the case "n_voltages > 1" in case of both get_voltage >> and get_voltage_sel are not implemented. > > Yes, I see the intention - what I'm saying is that a regulator like that > makes no sense in the first place. We do have such case in drivers/regulator/max1586.c /* * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back * the set up value. */ static struct regulator_ops max1586_v3_ops = { .set_voltage_sel = max1586_v3_set_voltage_sel, .list_voltage = regulator_list_voltage_linear, .map_voltage = regulator_map_voltage_linear, }; static struct regulator_ops max1586_v6_ops = { .set_voltage_sel = max1586_v6_set_voltage_sel, .list_voltage = regulator_list_voltage_table, }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/