Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870Ab2HKUvc (ORCPT ); Sat, 11 Aug 2012 16:51:32 -0400 Received: from mail.vyatta.com ([76.74.103.46]:35317 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754711Ab2HKUuz (ORCPT ); Sat, 11 Aug 2012 16:50:55 -0400 Date: Sat, 11 Aug 2012 13:50:44 -0700 From: Stephen Hemminger To: Cc: , , , , , Xiong Huang , "Hao-Ran Liu(Joseph Liu)" , Joe Perches , "Luis R. Rodriguez" Subject: Re: [PATCH] net: add new QCA alx ethernet driver Message-ID: <20120811135044.529a7081@nehalam.linuxnetplumber.net> In-Reply-To: <1344507270-2907-1-git-send-email-cjren@qca.qualcomm.com> References: <1344507270-2907-1-git-send-email-cjren@qca.qualcomm.com> Organization: Vyatta X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 447 Lines: 12 On Thu, 9 Aug 2012 18:14:30 +0800 wrote: > + strcpy(netdev->name, "eth%d"); > + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/