Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755138Ab2HLCKV (ORCPT ); Sat, 11 Aug 2012 22:10:21 -0400 Received: from mga11.intel.com ([192.55.52.93]:35485 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271Ab2HLCKT (ORCPT ); Sat, 11 Aug 2012 22:10:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,753,1336374000"; d="scan'208";a="198216724" Date: Sun, 12 Aug 2012 10:10:13 +0800 From: Fengguang Wu To: Michael Cree Cc: linux-alpha@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Tony Luck , James Bottomley , John David Anglin , Mel Gorman , kernel-janitors@vger.kernel.org, Kyle McMartin , Andrew Morton , LKML , Parisc List Subject: Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant Message-ID: <20120812021013.GA8442@localhost> References: <1343042420.3027.11.camel@dabdike.int.hansenpartnership.com> <20120723114258.GV9222@suse.de> <20120723122905.GA22476@localhost> <20120724074844.GA9519@localhost> <1343193053.3139.6.camel@dabdike> <20120802150209.GA26601@localhost> <502707D5.7020602@orcon.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <502707D5.7020602@orcon.net.nz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1795 Lines: 46 On Sun, Aug 12, 2012 at 01:33:09PM +1200, Michael Cree wrote: > On 03/08/12 03:02, Fengguang Wu wrote: > > On Thu, Jul 26, 2012 at 10:06:41AM -0700, Tony Luck wrote: > >> On Tue, Jul 24, 2012 at 10:10 PM, James Bottomley > >> wrote: > >>>> Here is the line in sock.i: > >>>> > >>>> struct static_key memalloc_socks = ((struct static_key) { .enabled = > >>>> ((atomic_t) { (0) }) }); > >>> > >>> The above line contains two compound literals. It also uses a designated > >>> initializer to initialize the field enabled. A compound literal is not a > >>> constant expression. > >> > >> Seeing the same thing on ia64 building next-20120726. Same fix works > >> for me ... so I'll steal this whole changelog and attributes. > > > > I got the same error for alpha, the same fix applies. > > Just trying this patch on Alpha against v3.6-rc1 and it leads to new > compilation errors, namely: > > init/init_task.c:12: error: braced-group within expression allowed only > inside a function > init/init_task.c:13: error: braced-group within expression allowed only > inside a function > init/init_task.c:16: error: braced-group within expression allowed only > inside a function > init/init_task.c:16: error: braced-group within expression allowed only > inside a function > make[1]: *** [init/init_task.o] Error 1 Sorry! This will actually compile: -#define ATOMIC_INIT(i) ( { (i) } ) +#define ATOMIC_INIT(i) { (i) } Ditto for the 64bit version. I'll send the updated patch. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/