Message-ID: <1344791104.3810.2.camel@joe2Laptop>
Subject: Re: [PATCH] be2iscsi: cleanup format strings using literal string
 concatenations
From: Joe Perches <joe@perches.com>
To: Masatake YAMATO <yamato@redhat.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sun, 12 Aug 2012 10:05:04 -0700
In-Reply-To: <1344785130-24172-1-git-send-email-yamato@redhat.com>
References: <1344785130-24172-1-git-send-email-yamato@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 892
Lines: 25

On Mon, 2012-08-13 at 00:25 +0900, Masatake YAMATO wrote:
> In format strings for printk in be2iscsi, literal c string
> concatenations are used widely. However, the log output is a bit
> difficult to read because whitespaces are missed in the literal c
> strings like:
> 
>     SE_DEBUG(DBG_LVL_1, "CQ Error %d, reset"
> 			"received/sent on CID 0x%x...\n",
> 
> You will see "CQ Error 0xffffffff resetreceived/sent on CID ..." and
> wonder what is "resetreceived".

It'd be even better to coalesce the formats so they'd be
easier to grep.  Just ignore 80 columns.

	SE_DEBUG(DBG_LVL_1,
		 "CQ Error %d, reset received/sent on CID 0x%x...\n",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/