Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442Ab2HLS5t (ORCPT ); Sun, 12 Aug 2012 14:57:49 -0400 Received: from natasha.panasas.com ([67.152.220.90]:55170 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899Ab2HLS5s (ORCPT ); Sun, 12 Aug 2012 14:57:48 -0400 Message-ID: <5027FC98.2040903@panasas.com> Date: Sun, 12 Aug 2012 21:57:28 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111113 Thunderbird/8.0 MIME-Version: 1.0 To: Sachin Bhamare CC: Alexey Khoroshilov , Benny Halevy , , , Subject: Re: [PATCH] exofs: check for allocation failure in uri_store() References: <1344445357-986-1-git-send-email-khoroshilov@ispras.ru> <5024075B.4090804@panasas.com> In-Reply-To: <5024075B.4090804@panasas.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 45 On 08/09/2012 09:54 PM, Sachin Bhamare wrote: > On 8/8/12 10:02 AM, Alexey Khoroshilov wrote: >> There is no memory allocation failure check in uri_store(). >> That can lead to NULL pointer dereference. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexey Khoroshilov >> --- >> fs/exofs/sys.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/fs/exofs/sys.c b/fs/exofs/sys.c >> index 5a7b691..1b4f2f9 100644 >> --- a/fs/exofs/sys.c >> +++ b/fs/exofs/sys.c >> @@ -80,8 +80,13 @@ static ssize_t uri_show(struct exofs_dev *edp, char *buf) >> >> static ssize_t uri_store(struct exofs_dev *edp, const char *buf, size_t len) >> { >> + uint8_t *new_uri; >> + >> edp->urilen = strlen(buf) + 1; >> - edp->uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL); >> + new_uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL); >> + if (new_uri == NULL) >> + return -ENOMEM; >> + edp->uri = new_uri; >> strncpy(edp->uri, buf, edp->urilen); >> return edp->urilen; >> } > Ack-by : Sachin Bhamare Has been pushed to linux-next will be included in the next RCX push to Linus. Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/