Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586Ab2HMBT3 (ORCPT ); Sun, 12 Aug 2012 21:19:29 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:20925 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767Ab2HMBT1 convert rfc822-to-8bit (ORCPT ); Sun, 12 Aug 2012 21:19:27 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6801"; a="224540189" X-IronPort-AV: E=Sophos;i="4.77,757,1336374000"; d="scan'208";a="305561401" From: "Huang, Xiong" To: Stephen Hemminger , "Ren, Cloud" CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , "Hao-Ran Liu(Joseph Liu)" , Joe Perches , "Rodriguez, Luis" Subject: RE: [PATCH] net: add new QCA alx ethernet driver Thread-Topic: [PATCH] net: add new QCA alx ethernet driver Thread-Index: AQHNddTRDXcTbtvZbUiDfP8UijeOlpdVj6IAgAFnQbA= Date: Mon, 13 Aug 2012 01:19:24 +0000 Message-ID: <157393863283F442885425D2C4542856282E0637@nasanexd02f.na.qualcomm.com> References: <1344507270-2907-1-git-send-email-cjren@qca.qualcomm.com> <20120811135044.529a7081@nehalam.linuxnetplumber.net> In-Reply-To: <20120811135044.529a7081@nehalam.linuxnetplumber.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.235.14.28] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 570 Lines: 16 > From: Stephen Hemminger [mailto:shemminger@vyatta.com] > Sent: Sunday, August 12, 2012 4:51 > To: Ren, Cloud > > + strcpy(netdev->name, "eth%d"); > > + retval = register_netdev(netdev); > > The strcpy is unnecessary, alloc_etherdev already sets that. Thanks, Hemminger, we will remove this line in the next post. -Xiong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/